Last modified: 2011-08-29 15:56:25 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 30575 - Make sure all callers to functions that require __METHOD__ parameter pass it
Make sure all callers to functions that require __METHOD__ parameter pass it
Status: NEW
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: code_quality
  Show dependency treegraph
 
Reported: 2011-08-25 22:12 UTC by Sam Reed (reedy)
Modified: 2011-08-29 15:56 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Sam Reed (reedy) 2011-08-25 22:12:25 UTC
Usually it's made optional, and is never in the same place, os it can be quite annoying..

More than once have bugs been found from wrong parameter orders, such as passing another parameter for the function name.

It's also just good practise, for profiling etc etc

Not sure if there is much that can be done to automagically scan the code for them...
Comment 1 Chad H. 2011-08-27 14:42:37 UTC
Just to clarify (I had to re-read this, the summary wasn't quite clear)...we're talking about functions like DB functions where we pass __METHOD__ and such.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links