Last modified: 2011-09-06 11:32:17 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T31916, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 29916 - add follow-up fetching to CR API
add follow-up fetching to CR API
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CodeReview (Other open bugs)
unspecified
All All
: Unprioritized enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 26416
  Show dependency tree / graph
 
Reported: 2011-07-15 22:21 UTC by Antoine "hashar" Musso (WMF)
Modified: 2011-09-06 11:32 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Antoine "hashar" Musso (WMF) 2011-07-15 22:21:17 UTC 
The CodeReview API does not let us fetch follow up for a given set of revisions. 

This could be made an option when querying for list=coderevisions. Each <revision> could contains more <revisions> elements.

An option could be added to handle this recursively. Possible traps:
- revisions might appear more than one time, we want to avoid sending the same metadata over and over.
- avoid loops!! :b
Comment 1 Brion Vibber 2011-07-15 22:35:26 UTC 
I'd avoid recursion here; easiest and safest to only show one level. :)
Comment 2 Sam Reed (reedy) 2011-07-16 00:10:27 UTC 
(In reply to comment #1)
> I'd avoid recursion here; easiest and safest to only show one level. :)

Indeed. Although unlikely (these aren't Wikipedia categories!!), I think doing 1 level makes sense

I'm guessing 1 level is just all the followup revisions for the passed numbers (not any followups to those)?
Comment 3 Sam Reed (reedy) 2011-07-17 01:48:35 UTC 
Also, what level of information do you want returning for the followups? Same as the GUI? More? Less?
Comment 4 Antoine "hashar" Musso (WMF) 2011-07-17 16:15:38 UTC 
Well it can be customized for list=coderevisions using crprop.

By default revid|status|author|timestamp I guess.
Comment 5 Sam Reed (reedy) 2011-09-06 11:32:17 UTC 
Done in r96321
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links