Last modified: 2011-06-01 01:11:18 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T31177, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 29177 - TimedMediaHandler / MwEmbedSupport's extension setup files define, execute functions
TimedMediaHandler / MwEmbedSupport's extension setup files define, execute fu...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
TimedMediaHandler (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Michael Dale
:
Depends on:
Blocks: 27699
  Show dependency treegraph
 
Reported: 2011-05-27 23:12 UTC by Brion Vibber
Modified: 2011-06-01 01:11 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Brion Vibber 2011-05-27 23:12:40 UTC
TimedMediaHandler.php contains this bit:

// Register the Timed Media Handler javascript resources ( MwEmbed modules ) 
MwEmbedResourceManager::register( 'extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer' );
MwEmbedResourceManager::register( 'extensions/TimedMediaHandler/MwEmbedModules/TimedText' );

which relies on the class being set up and ready to execute via earlier code.

Defining and then using classes & functions in the setup files is dangerous and I think may interfere with HipHop compatibility.
Comment 1 Michael Dale 2011-06-01 01:11:18 UTC
fixed in r89246

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links