Last modified: 2012-10-04 09:53:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T31076, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 29076 - "Main Page" link is removed in vectorTabs
"Main Page" link is removed in vectorTabs
Status: RESOLVED INVALID
Product: Wikimedia
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Krinkle
:
Depends on:
Blocks: 32578 40760
  Show dependency treegraph
 
Reported: 2011-05-21 18:17 UTC by Srikanth Logic
Modified: 2012-10-04 09:53 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Srikanth Logic 2011-05-21 18:17:45 UTC
The text "Main Page" in some language wikipedias appears as a broken text instead of a hyper link. Some script overwrites the vectorTab caption as plain text as opposed to be a hyper link.

Screenshot:- http://tawp.in/r/2bgy regarding the problem.

This bug is present in Tamil,Telugu wikipedias and other wiki-sister projects.

http://ta.wikipedia.org
http://ta.wiktionary.org
http://te.wikipedia.org

and possibly many more. However not all language Wikis have this problem, Malayalam and Bengali seems to work fine.
Comment 1 sodabottle 2011-05-21 20:36:30 UTC
(In reply to comment #0)
> The text "Main Page" in some language wikipedias appears as a broken text
> instead of a hyper link. Some script overwrites the vectorTab caption as plain
> text as opposed to be a hyper link.
> 
> Screenshot:- http://tawp.in/r/2bgy regarding the problem.
> 
> This bug is present in Tamil,Telugu wikipedias and other wiki-sister projects.
> 
> http://ta.wikipedia.org
> http://ta.wiktionary.org
> http://te.wikipedia.org
> 
> and possibly many more. However not all language Wikis have this problem,
> Malayalam and Bengali seems to work fine.


:This problem is because of the updates to "Main Page layout fixes" in common.js maintained by [[User:AzaToth]], [[User:R. Koot]], [[User:Alex Smotrov]] not being propagated to the wikis in question. Wikis still using the "mainPageRenameNamespaceTab" function (which is loaded by the "addOnloadHook") will face this problem. I have put in a fix for ta wiki, but i guess, we will have to completely rewrite common.js to be in sync with enwiki and other leading wikis
Comment 2 Krinkle 2011-05-21 23:03:08 UTC
This is happening due to a local script which assummed the <span> element was the only element inside the <li> tag, and overwrite the inner contents.

This removed the <a> tag inside the <span> for skins like Vector.

Instead the script should look for the <a> tag and replace the text of tag. That way the script will be shorter and it will work in both Vector and Monobook.

See also http://www.mediawiki.org/wiki/Snippets/Main_Page_tab

I've applied the fix.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links