Last modified: 2011-05-31 09:01:36 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 28881 - remove page number from dimensions
remove page number from dimensions
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
PagedTiffHandler (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Markus Glaser
:
Depends on:
Blocks: 28868
  Show dependency treegraph
 
Reported: 2011-05-08 09:54 UTC by John Mark Vandenberg
Modified: 2011-05-31 09:01 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description John Mark Vandenberg 2011-05-08 09:54:17 UTC
spawning from bug 28868 comment 2, please remove "page x" from the dimensions.

I don't think the dimensions field should change depending on the page you are
viewing.  The page being viewed is not a dimension.  The dimensions are listed
underneath the current image, *however* that is in round brackets after "Full
resolution‎".  When the user clicks on "Full resolution", they don't download
only 'page 2' when they are viewing page two - the entire document is
downloaded.

The tiff viewer is displaying 'page 1' for single page images (e.g.
[[File:D.tiff]]) which incorrectly suggests there are multiple pages.

I uploaded a multiframe tiff here
[[File:International Convention for Regulation of Whaling.tiff]]
Comment 1 Markus Glaser 2011-05-31 07:51:45 UTC
as noted in bug 28868 comment 6 I removed the page number for PagedTiffHandler in r88006. 

However, there are some things to say (sorry for posting this again):
* I know of multipage tiffs where height and width vary over the pages. At the
moment, in the short description, the resolution of the first page is used, and
in long description, the resolution of the currently shown page is used. I
couldn't think of a better solution, so if you have any thoughts...
* There is no real indicator any more on which page you are when viewing a
multipage image. There is the correct page number next to "Go to page", but,
obviously, the label says something different. I suggest we put a text above,
saying "Current page" with the page number and set the number next to "go to
page" to the next page.

Any thoughts?
Comment 2 John Mark Vandenberg 2011-05-31 09:01:36 UTC
Great.  I think this bug can be closed now.

If a multipage file has varying height and width, the *file* dimensions could/should say that. (djvu and pdf can also have varying page dimensions throughout)  Having a separate hook for *image* dimensions would help improve support for multipage formats.

I like your proposed solution for displaying the current page number.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links