Last modified: 2013-05-04 11:58:58 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T30835, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 28835 - Styling for p-personal menu in Vector
Styling for p-personal menu in Vector
Status: RESOLVED WONTFIX
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
unspecified
All All
: Normal enhancement with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy, patch, patch-need-review
Depends on:
Blocks: 44881
  Show dependency treegraph
 
Reported: 2011-05-05 13:37 UTC by Erwin Dokter
Modified: 2013-05-04 11:58 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screemshot of proposed styling (151.97 KB, image/png)
2011-05-05 14:34 UTC, Erwin Dokter
Details
Patch file for phase3/skins/vector/screen.css (967 bytes, patch)
2011-05-05 16:00 UTC, Erwin Dokter
Details
Divider image used by CSS (132 bytes, image/png)
2011-05-05 16:04 UTC, Erwin Dokter
Details
Patch file for phase3/skins/vector/screen.css (1002 bytes, patch)
2011-05-05 19:47 UTC, Erwin Dokter
Details
Patch file for phase3/skins/vector/screen.css (979 bytes, patch)
2011-05-05 21:12 UTC, Erwin Dokter
Details
Patch file for phase3/skins/vector/screen.css (961 bytes, patch)
2011-05-05 22:48 UTC, Erwin Dokter
Details
Patch file for trunk/phase3/skins/vector/screen.css (1.03 KB, patch)
2011-05-06 11:38 UTC, Erwin Dokter
Details
Patch file for trunk/phase3/skins/vector/screen.css (1.03 KB, patch)
2011-05-06 11:42 UTC, Erwin Dokter
Details

Description Erwin Dokter 2011-05-05 13:37:43 UTC
I like Vector, but the personal links look too much like the old Monobook links (no seperator whatsoever) and there is no styling to speak of that really integrates them into the Vector skin, as is the case in other skins.

So I tried 'vectorizing' them. First I tried up-side-down tabs, but that required rewriting the HTML. As the best solution is ususally the simplest, I came up with simple CSS that inserts a thin fading line between the links ([[File:Portal-break-v-vector.png]], inspired by Portal-break.png used in the left sidebar).

This really makes the links part of the skin, without becoming obtrusive in any way.

Changes required in skins-1.17/vector/main-ltr.css:

BEGIN PATCH

/* Personal */
#p-personal {
CHANGE:
	right: 0.75em;
TO:
	right: 0.25em;
}

/* This one flips! */
#p-personal li {
REMOVE:
	margin-left: 0.75em;
	margin-top: 0.5em;
ADD:
	margin: 0;
	padding: 0.5em;
}

/* Icon for Usernames */
#pt-userpage,
#pt-anonuserpage,
#pt-login {
CHANGE:
	background: url(images/user-icon.png?1) left top no-repeat;
TO:
	background: url(images/user-icon.png?1) no-repeat left;

ADD:
#pt-mytalk,
#pt-preferences,
#pt-watchlist,
#pt-mycontris,
#pt-logout {
	background: url("http://upload.wikimedia.org/wikipedia/commons/8/8a/Portal-break-v-vector.png") no-repeat left; /* Upload to bits.wikimedia.org! */
}

END PATCH

To preview this styling, put the following in your personal vector.css:

/* Personal menu styling preview */
#p-personal {
  right: 0.25em;
}
#p-personal li {
  margin: 0;
  padding: 0.5em;
}
#pt-login,
#pt-userpage,
#pt-anonuserpage {
  background-position: left;
}
#pt-mytalk,
#pt-preferences,
#pt-watchlist,
#pt-mycontris,
#pt-logout {
  background: url("http://upload.wikimedia.org/wikipedia/commons/8/8a/Portal-break-v-vector.png") no-repeat left;
}
Comment 1 Erwin Dokter 2011-05-05 13:41:33 UTC
(Note that Bugzilla adds unwanted linebreaks in the background rules.)
Comment 2 Roan Kattouw 2011-05-05 13:44:53 UTC
Could you attach an actual patch file? That would be much easier for us to work with. A screenshot of the new styling would also be useful.
Comment 3 Erwin Dokter 2011-05-05 14:33:14 UTC
Is there any software to create such a patchfile, or is there any formatting document I can look into to create one?

Screenshot attached.
Comment 4 Erwin Dokter 2011-05-05 14:34:21 UTC
Created attachment 8501 [details]
Screemshot of proposed styling
Comment 5 Roan Kattouw 2011-05-05 14:37:55 UTC
(In reply to comment #3)
> Is there any software to create such a patchfile, or is there any formatting
> document I can look into to create one?
> 
> Screenshot attached.
Under Linux, diff -u screen.css-from-SVN screen.css-with-your-changes will do it (note that main-ltr.css is called screen.css in MediaWiki 1.17), as will svn diff if you have an SVN checkout. Under Windows, TortoiseSVN can generate diff/patch files for local changes to an SVN checkout.
Comment 6 Erwin Dokter 2011-05-05 16:00:34 UTC
Created attachment 8502 [details]
Patch file for phase3/skins/vector/screen.css
Comment 7 Erwin Dokter 2011-05-05 16:04:13 UTC
Created attachment 8503 [details]
Divider image used by CSS

The patch asumes this file is located in skins/vector/images/
Comment 8 Erwin Dokter 2011-05-05 19:47:34 UTC
Created attachment 8507 [details]
Patch file for phase3/skins/vector/screen.css

Added #pt-anontalk and #pt-newmessages (only used on mediawiki.org).
Comment 9 Erwin Dokter 2011-05-05 21:12:12 UTC
Created attachment 8510 [details]
Patch file for phase3/skins/vector/screen.css

Grouped #pt- declarations.
Comment 10 Erwin Dokter 2011-05-05 22:48:39 UTC
Created attachment 8511 [details]
Patch file for phase3/skins/vector/screen.css

Removed #pt-newmessages; should be added to LiquidThreads' CSS file.
Comment 11 Erwin Dokter 2011-05-06 11:38:32 UTC
Created attachment 8514 [details]
Patch file for trunk/phase3/skins/vector/screen.css

Optimized even further. No longer requires seperate CSS for extensions (like LiquidThreads) that inject their own menu items.

This should be the last modification to the patch. Comments welcome. Hoping this makes it into 1.17 final.
Comment 12 Erwin Dokter 2011-05-06 11:42:41 UTC
Created attachment 8515 [details]
Patch file for trunk/phase3/skins/vector/screen.css

Fixed typo in code.
Comment 13 Erwin Dokter 2011-05-06 11:47:29 UTC
New code for testing/previewing to put in your personal vector.css file:

/* Personal menu dividers */
#p-personal {
  right: 0.25em;
}
#p-personal li {
  margin: 0;
  padding: 0.5em;
  background: url("http://upload.wikimedia.org/wikipedia/commons/6/6c/Personal-break-vector.png") no-repeat left;
}
li#pt-login,
li#pt-userpage,
li#pt-anonuserpage {
  background: url(/skins-1.17/vector/images/user-icon.png) no-repeat left;
}

(Mind the linebreaks.)
Comment 14 Trevor Parscal 2011-06-09 18:12:51 UTC
Vector's design was mostly about removing the majority of the lines from the Monobook skin. Adding these lines goes against that goal in my opinion.

Earlier designs of what eventually became vector actually collapsed most of the user tools into a hover-to-open menu (like how the actions menu works), but early feedback indicated that was a bridge to far for users who had developed strong habits involving the user tools, so we left them be. Nonetheless, I'm in favor of reducing the number of initially visible symbols/lines/words/icons/etc in the top of the page. Again, a view that's contrary to this patch.
Comment 15 Bugmeister Bot 2011-08-19 19:12:58 UTC
Unassigning default assignments. http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/54734
Comment 16 Erwin Dokter 2013-05-04 11:58:58 UTC
Withdraing; patch outdated, and skin is in too much flux.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links