Last modified: 2013-07-30 00:10:54 UTC
WebInstaller_Install does not check for warnings from the installation steps, so failure of the mediawiki-announce subscription and the mt_rand() security warning are not reported to the user. Also, the use of Http::post() instead of MWHttpRequest::factory()->execute() means that the status object generated by the Http module is thrown away. So very little information could be reported to the user even if warnings were checked for. The subscription step failed for me once and then worked the next three times. I don't know why.
r88946 The mt_rand warnings were there, but maybe they weren't showing. I changed the code to use MWHttpRequest and verified that errors showed.
It seems I was using a test URL to induce failure that was returning an HTTP status code of 200, namely: https://lists.wikimedia.org/mailman/subscribe/nonexistent r88946 doesn't change anything. The error message from MWHttpRequest is still thrown away, since config-install-subscribe-fail hasn't been updated to include $1. A warning box is shown for a 404 error with the revision reverted. It would be nice if the response body was checked against a regex to ensure that subscription did actually occur. Then server-side errors in Mailman would be reported to the user. Reopening, lowering priority and removing 1.17 blocker.
