Last modified: 2010-05-15 15:38:02 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T4855, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 2855 - (Page author) credit string shows realname, even if $wgAllowRealName is false (disabled)
(Page author) credit string shows realname, even if $wgAllowRealName is false...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
1.5.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-07-14 12:55 UTC by T. Gries
Modified: 2010-05-15 15:38 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description T. Gries 2005-07-14 12:55:19 UTC
Having
$wgAllowRealName = false;
$wgMaxCredits = 1;

Credits on page bottoms are given to RealName even in the case, that RealName is globally 
OFF. In such cases, credits should show _username(s)_ instead. Irrespective of field 
RealName being empty or not, it should follow the setting of $wgAllowRealName.
Comment 1 T. Gries 2005-08-11 00:03:10 UTC
The problem is somewhere in Credits.php, where also some code cosmetics should
take place.

My observations - how to reproduce the problem:

0. have wgMaxCredits = 0
1. start with $wgAllowRealName = true and set a user name but no real name yet
2. set wgMaxCredits = 1
3. watch the attribution credits line how it changes from username to realname -
when you enter a real name in user-prefs (=ok)
4. NOW set $wgAllowRealName = false
5. NOW watch the attribution credits line: it keeps on showing the _real_name_
regardless of any further changes of $wgAllowRealName. This isn't a cache problem.

It looks, as if a bug is lurking in Credits.php.

Please can someone explain, how the contribution line should look like if real
name _and_ user name are available w.r.t. to the setting of $wgAllowRealName . I
expect, that the username is shown, if $wgAllowRealName is false, btu the
software works differently: it prefers to show real name, if this is present in
the database.

An explanation of the wanted behaviour and a correction (bug fix) is kindly
requested.
Comment 2 Antoine "hashar" Musso (WMF) 2005-08-13 09:03:44 UTC
Fixed in 1.5 and HEAD
Comment 3 Rob Church 2006-03-26 02:46:51 UTC
(sigh) Please mark fixed bugs as such.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links