Last modified: 2011-04-08 18:45:12 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T30320, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 28320 - UploadWizard duplicate image content (hash) check is broken
UploadWizard duplicate image content (hash) check is broken
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UploadWizard (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Neil Kandalgaonkar
:
Depends on:
Blocks: 27260
  Show dependency treegraph
 
Reported: 2011-03-30 02:22 UTC by Neil Kandalgaonkar
Modified: 2011-04-08 18:45 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Neil Kandalgaonkar 2011-03-30 02:22:01 UTC
Duplicate checking suddenly isn't working.

This may be related to recent changes to the Title::verifyTitlePermissions() API.
Comment 1 Neil Kandalgaonkar 2011-04-08 18:26:18 UTC
This bug is only hit if you are trying to upload a file with both the same filename and the same content.

The problem is that the API returns only one error at a time. It believes that same-filename error is more important, so it returns that one. Conversely, we believe that same filename isn't important yet (since we plan to surface that problem later), so we ignore it.

Solution?

- swap the priority of those messages in the API ?

- give the API some placeholder random filename for now so same-filename isn't even triggered at this point? We suppress the error if it occurs anyway.
Comment 2 Ryan Kaldari 2011-04-08 18:30:41 UTC
We could check for same hash separately:
api.php?action=query&list=allimages&format=json&aisha1=<hash>
...and make sure the number of matches is 0.
Comment 3 Neil Kandalgaonkar 2011-04-08 18:45:12 UTC
fixed in r85683

used placeholder semi-random filename

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links