Last modified: 2011-04-06 05:20:25 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T30315, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 28315 - Show a spinner on initial load
Show a spinner on initial load
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UploadWizard (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Ryan Kaldari
:
Depends on:
Blocks: 27260
  Show dependency treegraph
 
Reported: 2011-03-30 01:30 UTC by Neil Kandalgaonkar
Modified: 2011-04-06 05:20 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
screenshot of problem on Mac OS X Chrome 10 (157.64 KB, image/png)
2011-04-06 04:00 UTC, Neil Kandalgaonkar
Details

Description Neil Kandalgaonkar 2011-03-30 01:30:14 UTC
Waiting for the tutorial and other page elements to show up can be irritating. Show a spinner to indicate something is happening.
Comment 1 Ryan Kaldari 2011-04-05 19:59:26 UTC
Fixed in r85465.
Comment 2 Neil Kandalgaonkar 2011-04-06 02:30:45 UTC
When I tried this on commons.prototype the spinner appeared above the UploadWizard and did not go away.

Check your solution again with an empty cache?
Comment 3 Ryan Kaldari 2011-04-06 03:27:32 UTC
Works for me in Firefox 4 and Safari. Are we testing the same page:
http://commons.prototype.wikimedia.org/wiki/Special:UploadWizard
Comment 4 Neil Kandalgaonkar 2011-04-06 04:00:52 UTC
Created attachment 8377 [details]
screenshot of problem on Mac OS X Chrome 10

See attachment.

I believe the problem is twofold:

1) When debug mode is off (as on prototype) ResourceLoader is going to load the spinner image and the rest of everything at the same time, within the same HTTP call. So if that's delayed, while RL packages something maybe, there's no benefit.

2) Something else about the way this loads is causing jQuery to get confused about making it visible. Possibly, since the div actually has zero content, it doesn't think it has to hide() it.
Comment 5 Neil Kandalgaonkar 2011-04-06 04:11:12 UTC
Also, another thing -- the spinner shouldn't be shown immediately. Otherwise we get a nasty flashing effect sometimes. It should only appear if the loading has taken more than 2 seconds. Easy to do with a timeout.
Comment 6 Neil Kandalgaonkar 2011-04-06 05:20:25 UTC
Okay, a bit of thrashing occurred as Kaldari and I overwrote each other's changes/ideas/concepts/whatever, but this appears to be fixed in r85517.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links