Last modified: 2011-05-17 13:10:08 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T30176, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 28176 - Review and enable CLDR extension
Review and enable CLDR extension
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Extension setup (Other open bugs)
unspecified
All All
: Highest enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: i18n
Depends on:
Blocks: 16699 22984
  Show dependency tree / graph
 
Reported: 2011-03-22 01:25 UTC by Sam Reed (reedy)
Modified: 2011-05-17 13:10 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Sam Reed (reedy) 2011-03-22 01:25:07 UTC 
This is logged as an action item, after noticing it on bug 22984

I've got a reasonable feeling that this would be useful for other places too...

Also for bug 16699, related to babel...
Comment 1 Tim Starling 2011-03-24 04:09:04 UTC 
Please guard the PHP file inclusions against path traversal, like what we now do in the core. You can use Language::isValidBuiltInCode().

Otherwise looks fine. My patch in r84664 should be backported so we will know if there is any performance problem.
Comment 2 Sam Reed (reedy) 2011-04-07 00:08:59 UTC 
r85598 does the path inclusion protection

Is this ok now?

I suspect we can just tag/branch it from the trunk copy to bring this into 1.17wmf1?
Comment 3 Roan Kattouw 2011-05-17 13:08:09 UTC 
OK per Tim, deployed to all wikis by me just now.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links