Last modified: 2011-03-28 23:11:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T30151, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 28151 - JS error when opening subtitle editor
JS error when opening subtitle editor
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
TimedMediaHandler (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Michael Dale
:
Depends on: 27023
Blocks:
  Show dependency treegraph
 
Reported: 2011-03-21 11:30 UTC by Roan Kattouw
Modified: 2011-03-28 23:11 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Roan Kattouw 2011-03-21 11:30:05 UTC
* Go to http://prototype.wikimedia.org/timedmedia/Main_Page
* Mouseover the coffee commercial video, click CC (closed captioning) -> Choose text -> Upload subtitles
* A dialog box titled "Loading subtitle error appears"
* The spinner in this dialog box spins forever

In the console:
mw.TimedTextEdit is not a constructor
[Break On This Error] (768 out of range 305)
Main_Page (line 768)

The line number information doesn't get any less useless in debug mode, and neither 'break on this error' nor 'break on all errors' in Firebug finds the error.

However, this is slightly worrying:
>>> mw.TimedTextEdit
undefined
Comment 1 Michael Dale 2011-03-21 17:45:01 UTC
These are some integration issues with the resource loader. Note the present resource loader debug mode is pretty broken for dynamically loaded resources per elements of bug 27023 ( we are "evaluating" included scripts instead of appending them to the dom and waiting for them to be parsed )

But yes it appears the timed text upload was not ported to the new resource loader. Will fix this and the other "subtitle" user interface flows issues identified in r28150
Comment 2 Michael Dale 2011-03-28 23:11:53 UTC
This feature of uploading text files has been removed for now. (its interface is much less cool than miro subs http://commons.wikimedia.org/wiki/Commons:Universal_Subtitles 
Miro subs is an extra 1 meg of JS so not going to be reviewed or included by default. 

Instead I will promote the "editing" / uploading of subtitles be handled via gadgets like universal subtitles.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links