Last modified: 2012-04-19 21:22:12 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T30083, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 28083 - Load MediaWiki:Filepage.css only when it exists
Load MediaWiki:Filepage.css only when it exists
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
1.17.x
All All
: Normal enhancement with 1 vote (vote)
: 1.18.0 release
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-03-16 22:40 UTC by Krinkle
Modified: 2012-04-19 21:22 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Krinkle 2011-03-16 22:40:27 UTC
The feature was added per bug 24212. However it unconditionally inserts a <link> tag, even if that message/page does not exist on the foreign wiki.
Comment 1 Krinkle 2011-03-16 22:46:39 UTC
Raising importance as this will save a cross-domain http request on all File-pages when the page doesn't exist (every page view of a File-page of a foreign file)
Comment 2 Bryan Tong Minh 2011-04-22 18:37:04 UTC
Server side check and cache the result?
Comment 3 Krinkle 2011-04-23 13:20:04 UTC
Note that this bug only occurs on the local wiki, not on the 'file sharing repository' itself.

So the wikis using another wiki as repository unconditionally include a <link> tag to foreign.wiki/MedaWiki:Filepage.css?action=raw.


eg. if MedaWiki:Filepage.css would not exist on Commons, it would not be loaded on Commons' File-pages, but on every en.wikipedia.org view of a commons-file it would be loaded.
Comment 4 Krinkle 2011-08-04 06:02:26 UTC
Fixed by r91031.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links