Last modified: 2011-03-14 12:07:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T29993, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 27993 - Wikidiff2 doesn't show differences for template changes


Summary:	Wikidiff2 doesn't show differences for template changes

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	wikidiff2 (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal normal (vote)
Target Milestone:	---
Assigned To:	Tim Starling

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2011-03-11 13:47 UTC by Niklas Laxström
Modified:	2011-03-14 12:07 UTC (History)
CC List:	1 user (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Niklas Laxström 2011-03-11 13:47:54 UTC

For example see the diff http://translatewiki.net/w/i.php?title=User%3AReedy&action=historysubmit&diff=2806883&oldid=2806882
and compare it to http://translatewiki.net/w/i.php?title=User:Reedy&oldid=2806882&action=edit and http://translatewiki.net/w/i.php?title=User:Reedy&direction=next&oldid=2806883&action=edit

Comment 1 Niklas Laxström 2011-03-13 16:53:38 UTC

It's not just templates: http://translatewiki.net/w/i.php?title=StatusNet:Bc0c3f5891f8d8468046c473b131bdbeb01b54ac-Crop/fi&diff=2716791&oldid=2444080

Comment 2 Tim Starling 2011-03-13 22:21:52 UTC

Can't reproduce. Try recompiling.

Comment 3 Niklas Laxström 2011-03-14 07:46:21 UTC

Didn't seem to help. I added a test that fails for me in r83872.

Libraries have been installed in:
   /www/sandwiki/extensions/wikidiff2/modules

If you ever happen to want to link against installed libraries
in a given directory, [...]
----------------------------------------------------------------------

Build complete.
Don't forget to run 'make test'.


=====================================================================
PHP         : /usr/bin/php 
PHP_SAPI    : cli
PHP_VERSION : 5.3.2-1ubuntu4.7
ZEND_VERSION: 2.3.0
PHP_OS      : Linux - Linux v22011026445052.yourvserver.net 2.6.35.11-vs2.3.0.36.33-netcup #1 SMP Mon Feb 7 08:00:09 UTC 2011 x86_64
INI actual  : /www/sandwiki/extensions/wikidiff2/tmp-php.ini
More .INIs  :  
CWD         : /www/sandwiki/extensions/wikidiff2
Extra dirs  : 
VALGRIND    : Not used
=====================================================================
TIME START 2011-03-14 07:38:44
=====================================================================
FAIL Diff test A [tests/001.phpt] 
PASS Diff test B [tests/002.phpt] 
FAIL Diff test C: https://bugzilla.wikimedia.org/show_bug.cgi?id=27993 [tests/003.phpt] 
=====================================================================
TIME END 2011-03-14 07:38:44

cat tests/003.diff 
007+   <td class="diff-deletedline"><div></div></td>
007-   <td class="diff-deletedline"><div>!!FUZZY!!Rajaa</div></td>
009+   <td class="diff-addedline"><div></div></td>
009-   <td class="diff-addedline"><div>Rajaa</div></td

Comment 4 Tim Starling 2011-03-14 12:00:28 UTC

Please try after r83886.

Comment 5 Niklas Laxström 2011-03-14 12:07:42 UTC

Tests pass and broken diffs show correctly after purging.

Note You need to log in before you can comment on or make changes to this bug.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links