Last modified: 2012-04-16 09:16:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T29577, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 27577 - Gallery perrow width is overestimated
Gallery perrow width is overestimated
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
unspecified
All All
: Normal minor with 1 vote (vote)
: ---
Assigned To: Derk-Jan Hartman
:
Depends on: 27540
Blocks: 26676 27339
  Show dependency treegraph
 
Reported: 2011-02-20 01:11 UTC by Derk-Jan Hartman
Modified: 2012-04-16 09:16 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Derk-Jan Hartman 2011-02-20 01:11:06 UTC
default gallery results in galleryboxes of 155px wide, with 4 px of padding. That makes for 159 pixels. Times 4 results in 636 pixels. The maxwidth of the gallery is however 680 pixels, which is significantly more.
Comment 1 Derk-Jan Hartman 2011-03-14 21:08:58 UTC
Caused by r77411

Fixed in r83965
Comment 2 Laurence 'GreenReaper' Parry 2011-05-02 03:07:35 UTC
It's underestimated now. I'm running on the 1.17 branch and I found I needed to change the maxwidth calculation to this to get the right number of columns:

$maxwidth = $this->mPerRow * ( $this->mWidths + self::THUMB_PADDING + self::GB_PADDING + self::GB_BORDERS + 1) + 1;
Comment 3 DieBuche 2011-05-02 17:44:50 UTC
Confirmed. Your fix is not enough; it starts breaking with more than 7 again. Tricky
Comment 4 DieBuche 2011-05-02 18:01:00 UTC
Fixed in r87266. Tested with perrow up to 15
Comment 5 DieBuche 2011-07-15 10:24:03 UTC
Refixed in r91573

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links