Last modified: 2011-01-14 20:43:39 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T28733, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 26733 - Wrap initial table creation in transaction
Wrap initial table creation in transaction
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Installer (Other open bugs)
1.17.x
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 26611
  Show dependency treegraph
 
Reported: 2011-01-14 20:35 UTC by Roan Kattouw
Modified: 2011-01-14 20:43 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Roan Kattouw 2011-01-14 20:35:31 UTC
Due to a local snafu one of the last lines in my tables.sql contained an SQL error. This caused all tables to be created, then that line to fail and the lines below to be skipped. However, when running the installer again it refused to run tables.sql because the tables were already there.

We should wrap the inital table creation in a transaction so any failure anywhere in tables.sql causes no tables to be created whatsoever.
Comment 1 Sam Reed (reedy) 2011-01-14 20:43:39 UTC
r80322

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links