Last modified: 2014-09-23 19:57:27 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T28562, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 26562 - Cannot unwatch a thread without javascript unless going to the thread page
Cannot unwatch a thread without javascript unless going to the thread page
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
LiquidThreads (Other open bugs)
unspecified
All All
: Low minor (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-01-04 10:52 UTC by Nikola Kovacs
Modified: 2014-09-23 19:57 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
modified pages/ThreadWatchView.php (457 bytes, application/x-php)
2011-01-04 10:54 UTC, Nikola Kovacs 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Nikola Kovacs 2011-01-04 10:52:45 UTC 
If you have javascript disabled, clicking on the unwatch link in the thread header doesn't work. It just takes you to a default thread view without unwatching the thread.

I'm attaching a modified pages/ThreadWatchView.php that fixes this.
Comment 1 Nikola Kovacs 2011-01-04 10:54:10 UTC 
Created attachment 7953 [details]
modified pages/ThreadWatchView.php

Calls $this->thread->root()->watch() or $this->thread->root()->unwatch() based on value of $request->getVal( 'action' ) in the constructor.
Comment 2 Nemo 2012-08-20 15:42:51 UTC 
+keyword

Going to the Thread: page, accessible from "permanent link", gives you access to the normal watch/unwatch buttons.
Comment 3 Sumana Harihareswara 2012-08-20 15:44:58 UTC 
Thanks for keywording, Nemo_bis, and thanks for the patch, Nikola! It'd be great if you'd put future patches into Git: https://www.mediawiki.org/wiki/Git/Tutorial  That'll get them reviewed faster.
Comment 4 Andre Klapper 2013-01-23 12:46:43 UTC 
Nikola:
You are welcome to use Developer access
  https://www.mediawiki.org/wiki/Developer_access
to submit this as a Git branch directly into Gerrit:
  https://www.mediawiki.org/wiki/Git/Tutorial

Putting your branch in Git makes it easier for us to review it quickly.
Thanks again!
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links