Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T28496, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 26496 - extract() sucks (change for explicit definition)

Summary:	extract() sucks (change for explicit definition)

Status: NEW Product: MediaWiki Classification: Unclassified Component: General/Unknown (Other open bugs) Version: unspecified Hardware: All All Importance: Normal normal (vote) Target Milestone: --- Assigned To: Nobody - You can work on this! URL: Whiteboard: Keywords: Depends on: Blocks: code_quality   Show dependency tree / graph		Reported: 2010-12-30 02:53 UTC by Sam Reed (reedy) Modified: 2012-08-10 18:27 UTC (History) CC List: 3 users (show) mah mediawiki-bugs tylerromeo See Also: Web browser: --- Mobile Platform: --- Assignee Huggle Beta Tester: ---

Attachments Add an attachment (proposed patch, testcase, etc.)

Description Sam Reed (reedy) 2010-12-30 02:53:55 UTC extract() makes variables appear from nowhere, and should really be cleaned up in most (all?) cases to be made explicit Comment 1 Krinkle 2010-12-30 03:51:09 UTC Although $var->extract( calls were also matched, here's a resultspage that may be useful to see visualy: http://toolserver.org/~krinkle/wikimedia-svn-search/view.php?id=59&hash=808b5bef729e4547355d3c659d16a0dd#F5 ViewVC links in the right column. Comment 2 Tyler Romeo 2012-08-10 18:22:21 UTC https://gerrit.wikimedia.org/r/gitweb?p=mediawiki%2Fcore.git&a=search&h=HEAD&st=grep&s=extract%28 Comment 3 Daniel Friesen 2012-08-10 18:27:38 UTC Heh... it's a shame PHP doesn't have destructuring assignment for non-numeiric arrays/objects.