Last modified: 2012-08-10 18:27:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 26496 - extract() sucks (change for explicit definition)
extract() sucks (change for explicit definition)
Status: NEW
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: code_quality
  Show dependency treegraph
 
Reported: 2010-12-30 02:53 UTC by Sam Reed (reedy)
Modified: 2012-08-10 18:27 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Sam Reed (reedy) 2010-12-30 02:53:55 UTC
extract() makes variables appear from nowhere, and should really be cleaned up in most (all?) cases to be made explicit
Comment 1 Krinkle 2010-12-30 03:51:09 UTC
Although $var->extract( calls were also matched, here's a resultspage that may be useful to see visualy:
http://toolserver.org/~krinkle/wikimedia-svn-search/view.php?id=59&hash=808b5bef729e4547355d3c659d16a0dd#F5

ViewVC links in the right column.
Comment 3 Daniel Friesen 2012-08-10 18:27:38 UTC
Heh... it's a shame PHP doesn't have destructuring assignment for non-numeiric arrays/objects.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links