Last modified: 2012-04-16 09:15:43 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T28375, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 26375 - Italics should be passed to TOC
Italics should be passed to TOC
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
http://en.wikipedia.org/w/index.php?t...
: need-parsertest, patch, patch-reviewed
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-12-20 15:43 UTC by gdonato
Modified: 2012-04-16 09:15 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
v. simple patch (736 bytes, patch)
2010-12-20 17:05 UTC, gdonato
Details

Description gdonato 2010-12-20 15:43:07 UTC
Submitting on behalf of those at WP:VPT.

Fairly simple report, italics should be represented on the table of contents in the same way as <sup> etc. in bug 8393. Perhaps other things should also be added e.g. bold? I don't know...
Comment 1 gdonato 2010-12-20 17:05:18 UTC
Created attachment 7920 [details]
v. simple patch

Very simple, adds <i>, <em> to regex. Probably insufficient.
Comment 2 Sumana Harihareswara 2011-11-06 14:38:38 UTC
gdonato, I am sorry that it took so very long for you to get a response to your patch.  Thank you for your contribution.  We are aiming at being much more responsive now and in the future.

Unfortunately, your patch now does not cleanly apply to trunk, since there have been so many changes since December of last year.  Would you be interested in updating it?

Also, you may be interested in joining the parser/visual editor mailing list to see what changes are happening in the parser: https://lists.wikimedia.org/mailman/listinfo/wikitext-l

Thanks, and again, my regrets.
Comment 3 Platonides 2011-11-06 15:10:52 UTC
It wasn't that outdated. The line was there, it was moved 203 lines below.
Fixed in r102179. I only whitelisted <i> since that's what we are generating from ''.
Also added parser test.
Comment 4 Antoine "hashar" Musso (WMF) 2011-12-06 10:51:02 UTC
Bold enabled as a followup with r105284

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links