Last modified: 2012-04-16 09:16:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 26354 - dummy cells (containing  ) in table.diff lack identifying CSS class
dummy cells (containing  ) in table.diff lack identifying CSS class
Product: MediaWiki
Classification: Unclassified
History/Diffs (Other open bugs)
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
  Show dependency treegraph
Reported: 2010-12-17 04:40 UTC by Thana
Modified: 2012-04-16 09:16 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Patch for wikidiff2.cpp (687 bytes, patch)
2012-01-03 13:07 UTC, Erwin Dokter

Description Thana 2010-12-17 04:40:13 UTC
screen-shot: r10xn4.png">

this is related to bug 25697.

i found when viewing multi-paragraph diffs such as the wall of text seen in the
above screen-shot it may be helpful to select adjacent paragraphs with the
cursor to copy and paste specific excerpts to another medium, if not for all the
textual formatting junk between each pair of lines.

setting the following css put me about halfway there. looks sweet without all
the +/−:
> .diff-marker { visibility:hidden; }

(note, "display:none;" didn't work so well because these cells have no analogue
in the header rows and having them disappear completely causes awful cell
malignment issues.)

unfortunately there's no easy/reliable way to get rid of the spaces in the cells
specified by:
> <td colspan="2">&nbsp;</td>

due to the lack of an identifying css class. perhaps we can call this element
another type of .diff-marker, or make up an appropriate name for it.

(actually this would be even more useful when previewing template subst output
in the "show changes" (wpDiff) view, in cases where i'm trying to copy multiple
lines of the previewed output for discussion's sake or to build a related
template, again without all the arithmetic signs, dimension-forcing dummy chars,
and other non-content junk.)
Comment 1 Erwin Dokter 2010-12-17 12:40:53 UTC
Actually, this is not so much related to bug 25697, which added a &nbsp; to empty .diff-marker cells, so no problem there.

The <td colspan="2">&nbsp;</td> has always been there; it spans 2 columns just to give empty space. But it coud do with a class. How about .diff-empty?
Comment 2 Thana 2010-12-17 20:22:13 UTC
> The <td colspan="2">&nbsp;</td> has always been there; it spans 2 columns just
> to give empty space. But it coud do with a class. How about .diff-empty?

okay, that sounds fine. or if these spaces are now redundant to those added
per your request in bug 25697 (and are no longer important to anyone) we
could see about removing them completely. regards.
Comment 3 Erwin Dokter 2010-12-17 21:21:53 UTC
As long as one cell in the row has content (either text or &nbsp;), there shouldn't be any danger of collapsing table rows. And since every row has a diff.marker cell with guaranteed content, removing the &nbsp; from <td colspan="2">&nbsp;</td> should be OK.
Comment 4 Erwin Dokter 2012-01-03 13:07:07 UTC
Created attachment 9790 [details]
Patch for wikidiff2.cpp

Add class="diff-empty" to empty rows.
Comment 5 Roan Kattouw 2012-01-03 13:19:00 UTC
Patch applied in r107883.

Note You need to log in before you can comment on or make changes to this bug.