Last modified: 2014-09-08 10:51:32 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T28312, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 26312 - Heading-field (section=new) uses same name/id as edit summary (action=edit)
Heading-field (section=new) uses same name/id as edit summary (action=edit)
Status: NEW
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
1.18.x
All All
: Normal enhancement with 2 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy
Depends on:
Blocks: 18654 section-editing
  Show dependency treegraph
 
Reported: 2010-12-12 14:44 UTC by Krinkle
Modified: 2014-09-08 10:51 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Krinkle 2010-12-12 14:44:23 UTC
The Heading-field uses the same name/id as the Summary causing javascript tools targetting the summary to mess up.

ie. a button to insert a template adds "; template Foobar added" to the summary, which is great otherwise, but when adding a new talkpage heading there is no summary so I'd expect the script to be unable to find a summary and do nothing.

Instead it does find a "summary" field and appends it to it.
Likewise there are gadgets replacing the summary with "/* Test */ section added" and inserting {{subst:test}}~~~~

This is great when editing the page, since it appends the template to the talkpage and sets the summary correct, but when using the "new section" button (&section=new) it litterly sets the title of message to "/* Test */ new section".

If these different field would have different name/id attribute values they can be targetted, detected and used appropiately.
Comment 1 Ryan Kaldari 2011-12-19 23:40:05 UTC
In other words, EditPage.php should provide separate inputs for the section
title and the edit summary, rather than using wpSummary for both.
Comment 2 Tim Starling 2011-12-19 23:46:06 UTC
(In reply to comment #1)
> In other words, EditPage.php should provide separate inputs for the section
> title and the edit summary, rather than using wpSummary for both.

Krinkle is saying there should only be one input on the section=new form, but it should have a different id: "I'd expect the script to be unable to find a summary and do nothing."
Comment 3 Ryan Kaldari 2012-03-07 23:45:55 UTC
EditPage.php can now handle separate section titles and edit summaries (as of 1.19). It should be rather trivial to change the edit form to take advantage of this.
Comment 4 Helder 2012-06-30 02:36:03 UTC
(In reply to comment #3)
> EditPage.php can now handle separate section titles and edit summaries (as of
> 1.19). It should be rather trivial to change the edit form to take advantage of
> this.

Adding "easy" keyword then.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links