Last modified: 2014-11-18 18:07:15 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T28163, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 26163 - Categories and IW links not visible on FlaggedRevs diff pages
Categories and IW links not visible on FlaggedRevs diff pages
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
FlaggedRevs (Other open bugs)
unspecified
All All
: Normal major with 6 votes (vote)
: ---
Assigned To: Priyanka Dhanda
:
Depends on:
Blocks: 26334
  Show dependency treegraph
 
Reported: 2010-11-29 12:53 UTC by Leinad
Modified: 2014-11-18 18:07 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Leinad 2010-11-29 12:53:14 UTC
After r75332 (see bug25289) diff mode is broken - categories and iw links are not visible.
Comment 1 Leinad 2010-11-30 19:59:43 UTC
I've changed severity to major level - this is uncomfortable situation when editors can't distinguish when missing cat and iw and when it is caused by a bug.

Please fix ASAP.
Comment 2 Priyanka Dhanda 2010-12-01 00:21:56 UTC
Should be fixed in r77515 (trunk). I did some testing on prototype.
Assigning to robla to figure out next steps.
Comment 3 Aaron Schulz 2010-12-01 01:05:35 UTC
(In reply to comment #2)
> Should be fixed in r77515 (trunk). I did some testing on prototype.
> Assigning to robla to figure out next steps.

Re-opening per CR comments, unfortunately :/
Comment 4 Rob Lanphier 2010-12-01 01:12:11 UTC
Correction:  fixed in r77516

Leinad, can you test that this is indeed fixed to your satisfaction?  We've deployed the fix to some of the prototype wikis, including:
http://prototype.wikimedia.org/pl.wikipedia.org/

Assuming Leinad feels like this is ready to go, I'd like to get Aaron and Chad's thoughts on deploying this fix as a one-off.  Barring a one-off deployment, this will almost certainly be in the batch of fixes we're slating for later this month.
Comment 5 Rob Lanphier 2010-12-01 01:32:07 UTC
Sorry Aaron, I hadn't read your comment on r77516 before replying here.  Looks like we shouldn't rush out a bad fix for this.
Comment 6 Priyanka Dhanda 2010-12-01 22:11:33 UTC
So clearly my fix is not going to work for this. I misunderstood how the parser gets those links out. For now, I think I'm going to change this to using an api call to get categories and langlinks. 
Taking this one back while I work on that.
Comment 7 Priyanka Dhanda 2010-12-14 01:09:54 UTC
Robla, can you verify the styles look like what you had in mind?

Commits in trunk: r77896, r77897, r77930, r78346. Commits in branches/priyanka-wmf-fixes: r77943, r77944, r78348
Comment 8 Rob Lanphier 2010-12-14 01:26:28 UTC
Yup, that's what I had in mind.
Comment 9 Leinad 2010-12-17 12:30:56 UTC
I see that bug is "resolved", so could you sync to Wikimedia projects?
Comment 10 Rob Lanphier 2010-12-20 21:47:28 UTC
Yup, the plan is to deploy on Wednesday
Comment 11 Rob Lanphier 2010-12-23 22:59:43 UTC
This has been deployed now.  Note, there's one workaround that was discussed elsewhere, but easy to miss if you were just following this bug.  Interwiki links are shown on the bottom of the page rather than in the sidebar.  See http://www.mediawiki.org/wiki/Special:Code/MediaWiki/77516 for the discussion and justification for this.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links