Last modified: 2012-04-12 13:55:14 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T28038, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 26038 - Replace hyphen with − in diff-marker
Replace hyphen with − in diff-marker
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
History/Diffs (Other open bugs)
1.16.x
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-11-21 11:36 UTC by Erwin Dokter
Modified: 2012-04-12 13:55 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Erwin Dokter 2010-11-21 11:36:37 UTC
In DifferenceEngine.php (line 1175), please replace '-' with '−', as the hyphen is barely visible, and − is equal width to '+'.
Comment 1 Derk-Jan Hartman 2010-11-21 12:01:11 UTC
Already done in r75662
Comment 2 Erwin Dokter 2010-11-21 21:30:22 UTC
I didn't catch that... Navigating SVN is a [female dog].
Comment 3 MZMcBride 2010-11-21 21:39:09 UTC
Are you familiar with bug 8327 and its associated revisions (r18468 and r18472)?
Comment 4 Erwin Dokter 2010-11-21 22:31:31 UTC
How is 8327 related. This minus is used to indicate removed text; not to denote a negative value.
Comment 5 Erwin Dokter 2011-02-26 04:42:41 UTC
It appears this must be patched in wikidiff2.cpp instead. I don't know if this has been done yet, therefor reopening.
Comment 6 Derk-Jan Hartman 2011-02-27 20:14:39 UTC
Done for wikidiff.cpp in r82905 and for wikidiff2.cpp in r82906

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links