Last modified: 2011-02-08 21:56:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T27919, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 25919 - NullRevision to a page should not produce pending changes for pages transcluding it
NullRevision to a page should not produce pending changes for pages transclud...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
FlaggedRevs (Other open bugs)
unspecified
All All
: Normal enhancement with 1 vote (vote)
: ---
Assigned To: Rob Lanphier
:
Depends on:
Blocks: 26334
  Show dependency treegraph
 
Reported: 2010-11-14 14:21 UTC by Umherirrender
Modified: 2011-02-08 21:56 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Umherirrender 2010-11-14 14:21:36 UTC
When block or unblock a page, a NullRevision is created (Revision::newNullRevision) and all pages which using this page as template have a pending change ("There are template/file changes awaiting review"). It is possible to ignore these changes for FlaggedRevs?

Thanks.
Comment 1 Umherirrender 2010-11-15 18:25:59 UTC
Addition: When a page from an unreviewable namespace is used as a template in a reviewable namespace and get a block, all the user of the template have to reviewed manual.
Comment 2 Aaron Schulz 2010-11-16 05:20:04 UTC
I don't think there is any effective way to check for this at all (skipping down the top X edits because they are null). Even with some rev_type flag or something, it would not be efficient like checking page_latest, so you would need a page_latest_unique or something.

This looks like a wontfix unfortunately.
Comment 3 Aaron Schulz 2010-11-24 01:00:13 UTC
Alternately, findPendingTemplateChanges() could fetch and compare the rev_text_id field for $revIdDraft and $revIdStable...at a performance penalty.
Comment 4 Aaron Schulz 2010-11-24 01:27:54 UTC
(In reply to comment #3)
> Alternately, findPendingTemplateChanges() could fetch and compare the
> rev_text_id field for $revIdDraft and $revIdStable...at a performance penalty.

Done in r77211. Shouldn't have little db effect.
Comment 5 Aaron Schulz 2010-12-21 22:57:17 UTC
(In reply to comment #4)
> (In reply to comment #3)
> > Alternately, findPendingTemplateChanges() could fetch and compare the
> > rev_text_id field for $revIdDraft and $revIdStable...at a performance penalty.
> 
> Done in r77211. Shouldn't have little db effect.

*Should have* I mean.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links