Last modified: 2012-05-09 01:30:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T27787, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 25787 - UploadWizard's error handling is totally broken
UploadWizard's error handling is totally broken
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UploadWizard (Other open bugs)
unspecified
All All
: Normal major (vote)
: ---
Assigned To: Neil Kandalgaonkar
:
Depends on:
Blocks: 27260 36680
  Show dependency treegraph
 
Reported: 2010-11-04 16:36 UTC by Roan Kattouw
Modified: 2012-05-09 01:30 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Roan Kattouw 2010-11-04 16:36:17 UTC
Try uploading a file to http://commons.prototype.wikimedia.org/uwd/Special:UploadWizard (whose upload API is broken right now, gonna leave it that way for now so this bug remains reproducible), and the following sequence of events will take place:

* Upload a file with a name that's unlikely to already be used on the wiki
* Spinner displays while the file uploads
* Spinner is replaced by a green checkbox and the text "OK"
* An alert box appears with "error : Internal error : An internal error occurred"
* The green checkbox disappears and the green OK text is replaced with the red text "[mwe-upwiz-failed]"
* An alert box appears with "huh?"
* According to Firebug, the file http://commons.prototype.wikimedia.org/uploadwizard-deployment/extensions/UploadWizard/resources/16px-Gnome-process-stop.svg.png is requested (this URL 404s), possibly explaining why the green checkbox isn't replaced with a red X or something
* After all this, "0 of 1" will change to "1 of 1", and the wizard will CONTINUE TO THE NEXT STEP as though nothing went wrong
* Finish the wizard, and the wizard will simply hang at the very last step

It gets even more fun when trying to upload a file with a name that already exists on the wiki, e.g. example.png . In that case, the error message in the firsts alert box is "error: overwrite: Overwriting an existing file is not allowed".
Comment 1 Neil Kandalgaonkar 2010-11-04 17:41:24 UTC
I understand the "WTF EVERYTHING IS BROKEN" tone here, but it's actually *less* broken than it used to be.

What you're seeing now is an artifact of it now knowing what actually went wrong, but not having the behavior to respond correctly. This is next on the agenda.

If you're thinking that's the sort of feature that should have been added first, well, I agree, but I had to write my own API handlers to make this even conceivable.
Comment 2 Neil Kandalgaonkar 2010-11-04 17:50:04 UTC
Anyway, thanks (really! not sarcastic!) for coding up the bugzilla item -- you did a lot of work codifying the problem. I just have to bridge the new error information with the new way of indicating an issue and it should work.
Comment 3 Roan Kattouw 2010-11-05 15:37:58 UTC
Also, whenever something goes wrong in the final api.php?action=upload call in the very last step of the wizard (in my case, HTTP 500 because of a fatal error caused by a botched merge), there is no error reporting whatsoever, the wizard just 'hangs' (i.e. the interface remains blurred and inactive forever).
Comment 4 Guillaume Paumier 2010-11-05 16:34:36 UTC
Merging bugzilla components "Multimedia Usability" and "Upload Wizard"
Comment 5 Neil Kandalgaonkar 2010-11-23 08:05:02 UTC
Largely fixed in r77136, at least for the first "upload" page.

Working on fixes for subsequent API calls going wrong.
Comment 6 Neil Kandalgaonkar 2011-03-19 02:11:39 UTC
Considering this bug closed, at least insofar as it represents upload error handling. 

Lots of revisions have fixed this, but the last holes should be plugged with

r84221, r84223, r84224, r84226, r84286, r84301, r84303.

For description page API errors refer to bug 24758.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links