Last modified: 2010-10-27 04:48:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T27661, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 25661 - non-FF "Dismiss for now." isn't a label for input
non-FF "Dismiss for now." isn't a label for input
Status: RESOLVED FIXED
Product: mwEmbed
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Michael Dale
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2010-10-26 21:07 UTC by Krinkle
Modified: 2010-10-27 04:48 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Krinkle 2010-10-26 21:07:02 UTC 
When I go to a video in Safari (Mac) the message that comes has a checkbox (which I asume sets a cookie) and a <span> next to with the the text (mwe-embedplayer-do_not_warn_again) "Dismiss for now."

This should be changed into a <label> instead with the "for" attribute set to the name/id of the checkbox so that clicking the label will toggle the checkbox aswell (pointing the checkbox itself can be tricky at times..(usability)).

--
Krinkle
Comment 1 Krinkle 2010-10-26 21:12:38 UTC 
I'm not sure if what's currently live on commons (loaded from prototype.wikimedia.org) is this - or that it is from the extension, but I found it over here:

http://svn.wikimedia.org/viewvc/mediawiki/branches/MwEmbedStandAlone/modules/EmbedPlayer/skins/mw.PlayerControlBuilder.js?view=markup#l758

The 
779	                                        $targetWarning.append( 
780	                                                $j('<span />')
781	                                                .text( gM( 'mwe-embedplayer-do_not_warn_again' ) )
782	                                        );

I guess should be changed to:
779	                                        $targetWarning.append( 
780	                                                $j('<label />')
781	                                                .text( gM( 'mwe-embedplayer-do_not_warn_again' ) )
782	                                                .attr( 'for', 'ffwarn_' + embedPlayer.id )
783	                                        );
Comment 2 Michael Dale 2010-10-27 04:48:10 UTC 
Oky, thanks for the fix committed in r75504
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links