Last modified: 2010-10-02 10:20:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T27338, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 25338 - Resource loader: incorrect input to makeList()
Resource loader: incorrect input to makeList()
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
ResourceLoader (Other open bugs)
1.17.x
All All
: Normal major (vote)
: ---
Assigned To: Trevor Parscal
:
Depends on:
Blocks: 24415
  Show dependency treegraph
 
Reported: 2010-09-27 14:57 UTC by Max Semenik
Modified: 2010-10-02 10:20 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Max Semenik 2010-09-27 14:57:57 UTC
Periodically seen on TWN:

/w/load.php?debug=false&lang=en&modules=site&only=scripts&skin=modern&version=1970-01-01T00%3A00%3A00Z: Exception: DatabaseBase::makeList: empty input

Stack trace:
#2 /www/w/includes/ResourceLoader.php(75): DatabaseBase->select('module_deps', Array, Array, 'ResourceLoader:...')
#3 /www/w/includes/ResourceLoader.php(294): ResourceLoader::preloadModuleInfo(Array, Object(ResourceLoaderContext))
#4 /www/w/load.php(48): ResourceLoader::respond(Object(ResourceLoaderContext))

All such exceptions I've seen happen with the Modern skin.
Comment 1 Niklas Laxström 2010-10-01 07:04:35 UTC
The crucial point here seems to be that the request really contains & instead of &.
Comment 2 Max Semenik 2010-10-01 19:42:17 UTC
[19:44:20] <MaxSem> Nikerabbit, can you check server logs if their user agents are the same?
[19:46:24] <+Nikerabbit> MaxSem: firefox
[19:46:29] <MaxSem> ugh
[19:46:54] *rakkaus* [01-Oct-2010 15:46:48] /w/load.php?debug=false&amp;lang=pt-br&amp;modules=translate-css&amp;only=styles&amp;skin=modern&amp;version=20100909T150640Z: Exception: DatabaseBase::makeList: empty input
[19:47:07] <+Nikerabbit> MaxSem: referer is http://translatewiki.net/w/i.php?title=Special%3ATranslate&task=untranslated&group=ext-0-wikimedia&language=rue&limit=1000
[19:47:31] <+Nikerabbit> okay that one was ie 6.0
[19:47:41] <MaxSem> every page seems to generate this very link
[19:47:55] <+Nikerabbit> referer http://translatewiki.net/wiki/Portal:Th
[20:35:56] <MaxSem> I think I can fix this bug, but I would like to narrow down the cause of such broken requests
[20:37:23] <+Nikerabbit> MaxSem: broken clients most likely
[20:37:36] <MaxSem> FF is broken?
[20:37:39] MaxSem doubts
[20:38:05] <+Nikerabbit> can't think of any other good explanation
[20:38:34] <MaxSem> and this happens only with modern skin
[20:48:48] <+Nikerabbit> MaxSem: are you sure?
[20:48:58] <+Nikerabbit> it's the default skin
[20:54:11] <MaxSem> http://translatewiki.net/wiki/Special:UserOptionStats/skin
[20:54:21] <MaxSem> it's popular but not universally used
[21:01:10] <MaxSem> all such errors I've found in my IRC logs are for modern
[21:01:50] <MaxSem> mhm
[21:04:50] <MaxSem> I vaguely recall I had problems with css/js not loading some time before. not sure if they disappeared after I switched from modern to vector
[21:05:04] <MaxSem> could be due to this bug
[21:05:49] <+Nikerabbit> I doubt that, we've had many other problems too
Comment 3 Max Semenik 2010-10-02 10:20:01 UTC
I've went ahead and plugged this hole in r74139.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links