Last modified: 2010-08-29 10:50:07 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T26931, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 24931 - Cannot mark thread as read: Call to a member function getPrefixedText() on a non-object in /api/ApiThreadAction.php
Cannot mark thread as read: Call to a member function getPrefixedText() on a ...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
LiquidThreads (Other open bugs)
unspecified
All All
: Normal major (vote)
: ---
Assigned To: Andrew Garrett
:
: 24964 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-08-25 06:50 UTC by Niklas Laxström
Modified: 2010-08-29 10:50 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Niklas Laxström 2010-08-25 06:50:40 UTC
Works for most threads on Special:NewMessages on twn, but I have at least one thread which cannot be marked as read. The following error is thrown:
PHP Fatal error:  Call to a member function getPrefixedText() on a non-object in /www/sandwiki/extensions/LiquidThreads/api/ApiThreadAction.php on line 65

Name of the thread is "Sidebar using UI language?"
Comment 1 Raimond Spekking 2010-08-28 16:12:17 UTC
*** Bug 24964 has been marked as a duplicate of this bug. ***
Comment 2 Andrew Garrett 2010-08-29 03:18:47 UTC
The thread was created outside the Thread namespace and subsequently deleted, because Thread doesn't appear in Language::getNamespaces, which is because Nikerabbit has been futzing with the Namespace code.

It seems to work on my trunk installation now.
Comment 3 Niklas Laxström 2010-08-29 08:59:00 UTC
I had to, since you requested the support for i18ned namespaces. If there is something wrong with the latest code, you should state it explicitly.

What I do know is that with the latest changes we are getting Internal Server Errors for those pages where the problematic thread would show.
Comment 4 Niklas Laxström 2010-08-29 09:03:42 UTC
Right, there seems to be actual problem of adding the namespaces if the hook is not available - either because the version check passes and we register into non-existing hook, or if the version check fails, we call that function directly instead of as delayed in extension setup functions.
Comment 5 Niklas Laxström 2010-08-29 10:50:07 UTC
Fixed in r71875.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links