Last modified: 2010-07-26 17:11:04 UTC
Many of us have probably done this at some point or another - Where we've committed without pressing save again, or a typo in a variable. Meaning we need a followup commit r69921 and then r69930 to fix it, for example Any chance of a hook to just literally do a syntax/sanity check of the commited code, aborting the commit if it doesn't check out?
For the reference: there is maintenace/checkSyntax.php which checks not only for syntax errors, but also for other common problems, such as BOM's. When run on working copy with --modified switch, it will check quickly only modified files. It's mentioned at <http://www.mediawiki.org/wiki/Manual:Pre-commit_checklist>, but that page is not advertised enough.
Pre-commit? Ugh... For the same reasons as bug 21211, this would be annoying. Not opposed to the idea in concept, but it needs some fleshing out. Perhaps if we can come up with a non-blocking way to do hooks first.
*** This bug has been marked as a duplicate of bug 20069 ***
