Last modified: 2014-07-28 19:59:15 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 23824 - Search & replace button is hard to find
Search & replace button is hard to find
Status: PATCH_TO_REVIEW
Product: MediaWiki extensions
Classification: Unclassified
WikiEditor (Other open bugs)
unspecified
All All
: Normal normal with 2 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
: design
Depends on:
Blocks: 63665 24493
  Show dependency treegraph
 
Reported: 2010-06-07 20:32 UTC by Platonides
Modified: 2014-07-28 19:59 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Problem screenshot (106.44 KB, image/png)
2010-06-07 20:32 UTC, Platonides
Details

Description Platonides 2010-06-07 20:32:34 UTC
Created attachment 7433 [details]
Problem screenshot

1. Disabling "Enable dialogs for inserting links, tables and more" doessn't make clear that it will also disable Search & replace button.

2. Search & replace button is hard to find in the toolbar unless you already know where it is (see image)
Comment 1 Krinkle 2011-06-22 00:33:54 UTC
*Mass-change: Move WikiEditor bugs to component and remove blocker bug where*
Comment 2 Bugmeister Bot 2011-08-19 19:12:52 UTC
Unassigning default assignments. http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/54734
Comment 3 Deepak Sharma 2014-07-26 19:00:11 UTC
(In reply to Platonides from comment #0)
> Created attachment 7433 [details]
> Problem screenshot
> 
> 1. Disabling "Enable dialogs for inserting links, tables and more" doessn't
> make clear that it will also disable Search & replace button.
> 
> 2. Search & replace button is hard to find in the toolbar unless you already
> know where it is (see image)

Hi, I am relatively new to mediawiki and thought this would be an easy bug to fix.
So, I gave it a try. 2nd part was quite clear to me and I have changed the location of search/replace button adjacent to insert buttons and since search/replace button has a left border, it will remain distinct from insert buttons (and easy to locate).
But, 1st part confused me a little. Are you refering to $wgWikiEditorFeatures array in Wikieditor.php file where you can disable the dialogs, or is it the "Enable wizards for inserting links, tables as well as Search and Replace button" in the Editing section of User Preferences? (I am using 1.23 and 1.24 versions of MW)

And also, in my opinion, since, disabling dialogs should either remove the button completely( if button solely depends on the usage of a dialog ) or use dialog-less way (like inserting tables) (and Wikieditor does exactly that).So, I think this should be clear enough.

Please correct me if I am wrong anywhere.
Comment 4 Gerrit Notification Bot 2014-07-28 19:59:13 UTC
Change 149925 had a related patch set uploaded by TheDJ:
Change location of Search-Replace Link adjacent to Insert Links

https://gerrit.wikimedia.org/r/149925

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links