Last modified: 2014-09-24 00:07:25 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T25583, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 23583 - Special:Upload JS does not consider wgCheckFileExtensions
Special:Upload JS does not consider wgCheckFileExtensions
Status: NEW
Product: MediaWiki
Classification: Unclassified
Uploading (Other open bugs)
unspecified
Other All
: Low minor (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-reviewed
: 24731 (view as bug list)
Depends on: 24217
Blocks: 24731
  Show dependency tree / graph
 
Reported: 2010-05-18 15:41 UTC by Sean Turley
Modified: 2014-09-24 00:07 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Proposed Patch (1.55 KB, patch)
2010-05-18 16:10 UTC, Sean Turley 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Sean Turley 2010-05-18 15:41:06 UTC 
The upload interface will only accept files compliant with wgFileExtensions *even* if wgCheckFileExtensions is set to false. The problem is in the file:

/skins/common/upload.js


My suggested fix is to make wgCheckFileExtensions a "<script> global" in includes/Skin.php or similar and then check it's value before doing the actual file extension checking in upload.js



My System:

Ubuntu 10.04 x64
Mediawiki 1.16wmf4 (r66440)
PHP 5.3.2-1ubuntu4.1 (apache2handler)
MySQL 5.1.41-3ubuntu12
Comment 1 Sean Turley 2010-05-18 16:10:21 UTC 
Created attachment 7383 [details]
Proposed Patch
Comment 2 Brion Vibber 2011-01-02 20:48:05 UTC 
*** Bug 24731 has been marked as a duplicate of this bug. ***
Comment 3 Brion Vibber 2011-01-02 20:49:36 UTC 
Hmm, perhaps it should just not export $wgFileExtensions if $wgCheckFileExtensions is off?
Comment 4 p858snake 2011-04-30 00:09:59 UTC 
*Bulk BZ Change: +Patch to open bugs with patches attached that are missing the keyword*
Comment 5 Sumana Harihareswara 2011-11-10 03:09:39 UTC 
Per Brion's suggestion in comment 3 I'm adding the "reviewed" keyword.  Thank you for the patch, Sean!  If you have time, please do consider revising your patch for us; if you'd like tips on approach, please talk with us in #mediawiki on freenode IRC, or on https://lists.wikimedia.org/mailman/listinfo/wikitech-l .  Thanks again.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links