Last modified: 2010-10-14 22:00:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 23457 - API: removeFromToolbar doesn't work for buttons
API: removeFromToolbar doesn't work for buttons
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UsabilityInitiative (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Trevor Parscal
:
Depends on:
Blocks: 24493
  Show dependency treegraph
 
Reported: 2010-05-10 08:14 UTC by Michael M.
Modified: 2010-10-14 22:00 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Michael M. 2010-05-10 08:14:31 UTC
The API-function removeFromToolbar doesn't remove buttons: They are neither in div's nor do they have a "tool"-class, so the code target += ' div[rel=' + data.tool + '].tool'; can't find anything.
Comment 1 Michael M. 2010-10-14 09:31:22 UTC
For the Wikieditor extension this bug got fixed in r74114. But it still exists in UsabilityInitiative/js/plugins/jquery.wikiEditor.toolbar.js
Comment 2 Trevor Parscal 2010-10-14 17:15:11 UTC
The fix was simple, it just needs to be backported...
Comment 3 Trevor Parscal 2010-10-14 22:00:09 UTC
r74788 (/branches/wmf/1.16wmf4/extensions/UsabilityInitiative/) and r74799 (/branches/REL1_16/extensions/UsabilityInitiative/) resolves this for deployment and release branches.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links