Last modified: 2014-11-20 19:27:58 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T24783, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 22783 - edit conflict while editing the last section of a page
edit conflict while editing the last section of a page
Status: NEW
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
1.22.0
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 52197 (view as bug list)
Depends on:
Blocks: section-editing 70163
  Show dependency treegraph
 
Reported: 2010-03-09 19:15 UTC by Umherirrender
Modified: 2014-11-20 19:27 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Umherirrender 2010-03-09 19:15:54 UTC
When answer to the user in the last section on village pump and a other user create a new section at the end of that page (with section=new) it is bad, when I get a edit conflict. It is very useful, when MediaWiki can merge these edits. Thanks.
Comment 1 Roan Kattouw 2010-03-09 20:45:30 UTC
I know that conflicts get suppressed for section=new edits (you can just append to the end of the page, doesn't matter if the page changed in the meantime), so the reverse situation (you submit first, then the section=new user submits) should be handled gracefully. I think this use case is trickier to handle right.
Comment 2 Nemo 2013-03-06 09:00:40 UTC
*** Bug 34580 has been marked as a duplicate of this bug. ***
Comment 3 Umherirrender 2013-03-06 18:57:58 UTC
This is not a dupe of the other.

Steps to reproduce:
* User A opens the last section of a page for edit
* User B adds a section with section=new to the same page
* User A pressed save and get a edit conflict against the text/section added by user B

When User A would edit another section except the last one, you would not get a edit conflict, because mediawiki can merge it (with wgDiff3 or so), but mediawiki cannot merge, when the old text and the new text has differences at the end.
Comment 4 Wikid77 2013-06-14 06:02:50 UTC
When 2 users run section=new within a minute of each other, then the 2nd new section sometimes "overwrites" the 1st new section. The result seems to be 2 different updates to the prior (base) revision, rather than a series of 2 updates, in tandem. I think the option for "section=new" must issue a read-lock of the page, then append and unlock, to let the 2nd editor read-lock, append and unlock the page as appending to the lastest prior revision, ensured by a read-lock, or semaphore lock, until each "section=new" is completed.
Comment 5 Umherirrender 2013-06-14 18:23:17 UTC
(In reply to comment #4)
> When 2 users run section=new within a minute of each other, then the 2nd new
> section sometimes "overwrites" the 1st new section. The result seems to be 2
> different updates to the prior (base) revision, rather than a series of 2
> updates, in tandem. I think the option for "section=new" must issue a
> read-lock
of the page, then append and unlock, to let the 2nd editor
> read-lock, append
and unlock the page as appending to the lastest prior
> revision, ensured by a
read-lock, or semaphore lock, until each
> "section=new" is completed.

There is no problem, when two users using section=new and append a new section to the end of the text
Comment 6 Jesús Martínez Novo (Ciencia Al Poder) 2013-07-28 18:15:59 UTC
*** Bug 52197 has been marked as a duplicate of this bug. ***
Comment 7 Chris McKenna 2013-08-02 18:59:48 UTC
I've been seeing this with increased frequency lately. There really should be no edit conflict between someone editing an existing section on the page and someone adding a new section.

I wonder if the end of a section is defined only by the start of a following section. As the last section on a page has no following section it therefore includes all the rest of a page. If the end of the last section of the page was given a defined end and a new section added content after this defined end rather than simply after the last content then this sort of edit conflict would not occur.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links