Last modified: 2011-01-25 00:23:59 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T24601, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 22601 - Change AssertEdit error display
Change AssertEdit error display
Status: RESOLVED INVALID
Product: MediaWiki extensions
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Low enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: noncoreapi
  Show dependency treegraph
 
Reported: 2010-02-21 01:25 UTC by Giftpflanze
Modified: 2011-01-25 00:23 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Giftpflanze 2010-02-21 01:25:14 UTC
Please turn on the Mediawiki extension AssertEdit on Wikipedia which is said on the English Wikipedia project page “Creating a bot” to be enabled on Wikipedia. When appending assert/nassert to the GET/POST parameters to index.php/api.php that should definitely fail, the site is delivered instead of denying it. Alternatively confirm that AssertEdit isn’t used with Wikipedia (anymore), so that one can correct that information on said Wikipedia page.
Comment 1 Sam Reed (reedy) 2010-02-21 01:27:14 UTC
http://en.wikipedia.org/wiki/Special:Version

It's listed as included into the site...
Comment 2 Gurch 2010-02-21 02:34:33 UTC
AssertEdit affects editing, not viewing.

http://en.wikipedia.org/w/index.php?title=Foobar&assert=bot -- normal
http://en.wikipedia.org/w/index.php?title=Foobar&action=edit&assert=bot -- assertion error message
Comment 3 Sam Reed (reedy) 2010-02-21 16:36:55 UTC
As an aside to this (ie it's not possible to tell if AssertEdit is installed via the Api help), i'm making a api documentation module for it...
Comment 4 Giftpflanze 2010-02-21 18:03:48 UTC
1. You were right: I forgot to use it with a modifying action. My fault.

2. As I play with it: Can the API return the assert *result* also as a MediaWiki-API-Error in the HTML header lines, or generally as an *error*? Or could this not be done due to the result/error implementation style? A failed assertion is not harmless and almost always (assert=user) returns in a login, doesn’t it?
Comment 5 Sam Reed (reedy) 2010-02-22 20:52:13 UTC
	if ( $assertName != '' ) {
		$pass = AssertEdit::callAssert( $assertName, false );
		if ( !$pass ) 
			$result['assert'] = $assertName;
	}

Currently, it just adds it... Adding to the results for the API, but not actually failing (leaving that upto the user etc etc)...

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links