Last modified: 2014-02-12 23:38:14 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 22594 - Bugs in MetadataEdit extension
Bugs in MetadataEdit extension
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
MetadataEdit (Other open bugs)
All All
: Normal normal (vote)
: ---
Assigned To: Alexandre Emsenhuber [IAlex]
Depends on:
  Show dependency treegraph
Reported: 2010-02-20 17:12 UTC by Alexandre Emsenhuber [IAlex]
Modified: 2014-02-12 23:38 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description Alexandre Emsenhuber [IAlex] 2010-02-20 17:12:50 UTC
+++ This bug was initially created as a clone of Bug #8790 +++

I have discovered a number of bugs in the $wgUseMetadataEdit code:

- "show changes" on the edit page does not include the metadata

- metadata edits can be lost or misordered during section edits
  - the current code will simply stuff the new/edited metadata into 
    the end of the section being edited, while leaving any existing
    metadata at the end of the article.

- the parser that extracts metadata appears to have a condition that
  can cause the loss of content from previous revisions.
  - i did not actually experience this bug, but in trying to understand 
    how the parser works, i discovered that it sometimes fails to 
    un-explode the content, which could in theory replace text with "Array"
    in the articles.  Look for the "$y = implode("]]", $y)" on line 70 of
    my patch.

- metadata ordering can change between normal edits, which makes
  history diffs messy.
  1. edit the page.  add a new whitelist metadata field to the 
     normal textbox.  save the page.  Note in the source of the new
     revision that your metadata is still in the middle of the article
  2. edit the page again.  add some new content in the normal textbox.
     save the page.  Note that the source of the new revision now has
     the metadata from step 1 located at the end of the text, rather
     than in the middle of it.

I believe that I have fixed these bugs, and I will attach the patch in
a moment.  The patch also includes two new hooks, which allow
an extension to replace both the metadata parser and the metadata 
textbox on the EditPage.  I believe that this patch will have zero 
impact on any installations that are not using $wgUseMetaDataEdit.
Comment 1 Siebrand Mazeland 2010-04-20 23:10:54 UTC
Remove patch/need-review, as no patch was attached. Keeping issue open, as the report is probably valid. Assigning to reporter.

Note You need to log in before you can comment on or make changes to this bug.