Last modified: 2014-09-24 01:29:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T24448, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 22448 - Disable the 'Show changes' button when no changes are done to page
Disable the 'Show changes' button when no changes are done to page
Status: RESOLVED DUPLICATE of bug 14431
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
unspecified
All All
: Normal enhancement with 1 vote (vote)
: ---
Assigned To: Elancev Michael
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-02-09 11:50 UTC by Calcey QA
Modified: 2014-09-24 01:29 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Added message when no changes founded (1.59 KB, patch)
2011-04-11 11:16 UTC, Elancev Michael
Details

Description Calcey QA 2010-02-09 11:50:22 UTC
Steps to reproduce:

1)Start editing random page
2)Click on show changes button without doing any changes to page

<<Texts called 'Current revision', 'Your text' will display >>


Expected outcome:
Disable the show changes button and enable only if the changes are made to page
                          or
Display an appropriate message saying 'No changes to display or something like that'
Comment 1 Roan Kattouw 2010-02-09 13:54:23 UTC
This is an enhancement request for MediaWiki in general, not specific to the UsabilityInitiative extension.
Comment 2 Elancev Michael 2011-04-11 11:16:07 UTC
Created attachment 8392 [details]
Added message when no changes founded

I've add message "No change was made to the text" ('diff-nochanges' in Messages*.php file) when nothing changed

For 1.16 version DifferenceInterface.php should be patched insted of DifferenceEngine.php
Comment 3 Krinkle 2011-04-11 12:35:45 UTC
(In reply to comment #2)
> For 1.16 version DifferenceInterface.php should be patched insted of
> DifferenceEngine.php

This is not a high priority feature or bug, I'm not sure we should patch 1.16 at all or 1.17 for that matter. HEAD is 1.18 right now.
Comment 4 p858snake 2011-04-30 00:10:14 UTC
*Bulk BZ Change: +Patch to open bugs with patches attached that are missing the keyword*
Comment 5 Sumana Harihareswara 2011-11-09 23:56:09 UTC
Elancev Michael, thank you for the patch, and sorry it's taken so long to get a response!  Adding the "need-review" keyword to signal that developers should review it.
Comment 6 Sumana Harihareswara 2012-05-25 02:42:25 UTC
Elancev Michael:

Thanks again for the patch.  My apologies on the wait for a response.  Are you interested in updating it, and using developer access to directly suggest it into our Git source control system?  That would get a faster review.

https://www.mediawiki.org/wiki/Developer_access

https://www.mediawiki.org/wiki/Git/Workflow#How_to_submit_a_patch
Comment 7 Nemo 2012-07-26 16:05:31 UTC
I'm not sure what this bug is actually supposed to ask; compare bug 14431.
Comment 8 Rd232 2012-07-26 21:26:36 UTC
(In reply to comment #7)
> I'm not sure what this bug is actually supposed to ask; compare bug 14431.

The patch seems to be the answer to bug 14431 (show a suitable message when "show changes" button is clicked and there aren't any changes). By contrast, THIS bug is asking for the "show changes" button not to be shown in the first place when there aren't any changes. This presumably requires clientside logic, not serverside.
Comment 9 Kevin Israel (PleaseStand) 2013-08-31 20:18:49 UTC

*** This bug has been marked as a duplicate of bug 14431 ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links