Last modified: 2010-02-05 14:07:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T24364, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 22364 - $wgUseExternalEditor prevents reuploading
$wgUseExternalEditor prevents reuploading
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
1.16.x
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-02-02 23:53 UTC by bugzilla
Modified: 2010-02-05 14:07 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description bugzilla 2010-02-02 23:53:32 UTC
If the Setting $wgUseExternalEditor = false is ion effect, no link to reupload a picture or file is present.

Cause:
In ImagePage.php l.606:
if( $wgUseExternalEditor && $this->img->exists() ) {
 $this->uploadLinksBox();
}

Fix:
if( $this->img->exists() ) {
 $this->uploadLinksBox();
}

AND surround l.573-584 with an if:
if( $wgUseExternalEditor  ) {
 $elink = $sk->link(
			$this->mTitle,
			wfMsgHtml( 'edit-externally' ),
			array(),
			array(
				'action' => 'edit',
				'externaledit' => 'true',
				'mode' => 'file'
			),
			array( 'known', 'noclasses' )
		);
		$wgOut->addHTML( '<li id="mw-imagepage-edit-external">' . $elink . ' <small>' . wfMsgExt( 'edit-externally-help', array( 'parseinline' ) ) . "</small></li>\n" );
}
Comment 1 Alexandre Emsenhuber [IAlex] 2010-02-05 14:07:49 UTC
Fixed in r62023.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links