Last modified: 2010-01-29 02:38:22 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T24310, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 22310 - In doMainQuery: 2x "$join_conds = array(); " (one is enough!)
In doMainQuery: 2x "$join_conds = array(); " (one is enough!)
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Recent changes (Other open bugs)
1.16.x
All All
: Lowest trivial (vote)
: ---
Assigned To: Nobody - You can work on this!
http://svn.wikimedia.org/viewvc/media...
: patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-01-29 00:52 UTC by T. Gries
Modified: 2010-01-29 02:38 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description T. Gries 2010-01-29 00:52:51 UTC
public function doMainQuery( $conds, $opts ) {
        global $wgUser;

        $tables = array( 'recentchanges' );
        $join_conds = array(); // 1.)
        $query_options = array( 'USE INDEX' => array('recentchanges' => 'rc_timestamp') );

        $uid = $wgUser->getId();
        $dbr = wfGetDB( DB_SLAVE );
        $limit = $opts['limit'];
        $namespace = $opts['namespace'];
        $invert = $opts['invert'];

        $join_conds = array(); // 2.) doublure
Comment 1 Chad H. 2010-01-29 02:38:22 UTC
Done in r61652

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links