Last modified: 2010-01-29 02:38:22 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 22310 - In doMainQuery: 2x "$join_conds = array(); " (one is enough!)
In doMainQuery: 2x "$join_conds = array(); " (one is enough!)
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Recent changes (Other open bugs)
1.16.x
All All
: Lowest trivial (vote)
: ---
Assigned To: Nobody - You can work on this!
http://svn.wikimedia.org/viewvc/media...
: patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-01-29 00:52 UTC by T. Gries
Modified: 2010-01-29 02:38 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description T. Gries 2010-01-29 00:52:51 UTC
public function doMainQuery( $conds, $opts ) {
        global $wgUser;

        $tables = array( 'recentchanges' );
        $join_conds = array(); // 1.)
        $query_options = array( 'USE INDEX' => array('recentchanges' => 'rc_timestamp') );

        $uid = $wgUser->getId();
        $dbr = wfGetDB( DB_SLAVE );
        $limit = $opts['limit'];
        $namespace = $opts['namespace'];
        $invert = $opts['invert'];

        $join_conds = array(); // 2.) doublure
Comment 1 Chad H. 2010-01-29 02:38:22 UTC
Done in r61652

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links