Last modified: 2014-11-17 10:36:05 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T23351, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 21351 - Diffview system - whitespace not properly indicated
Diffview system - whitespace not properly indicated
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
wikidiff2 (Other open bugs)
unspecified
All All
: Normal trivial with 2 votes (vote)
: ---
Assigned To: Tim Starling
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-10-30 03:25 UTC by Scott Jackson
Modified: 2014-11-17 10:36 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
The diff with 1.19wmf1 (r114429) and gadget "Display diffs with the new yellow/blue color scheme and design that improves accessibility. (based on r133098)" (126.18 KB, image/png)
2012-04-13 08:44 UTC, Nemo
Details
Same diff of "Contractor selection" without style improvements (248.53 KB, image/png)
2012-04-13 08:45 UTC, Nemo
Details

Description Scott Jackson 2009-10-30 03:25:05 UTC
http://en.wikipedia.org/w/index.php?title=Ares_I&action=historysubmit&diff=317703369&oldid=317700423

Note that the highlighted lines are not the lines which have changed. This is minor and probably a lot more than trivial to fix. However, the lines above any of the changes are also highlighted as changed. What's going on here?

If I missed a dupe forgive me, I searched and came up with naught.
Comment 1 OverlordQ 2009-10-30 03:41:28 UTC
Differences in whitespace will show up like that.

EG, in the first large block of text is in the old revision is:

{{Cite web |url=

In the new revision:

{{Cite web| url=

It's kinda of hard to make whitespace in red to show that it changed.  Likely INVALID as described.
Comment 2 OverlordQ 2009-10-30 04:13:58 UTC
Well I take that back, since a printable has moved, in this case usually a pipe, if it showed up highlighted it'd make this more apparent.

Changing component to wikidiff2.
Comment 3 Krinkle 2010-05-03 23:35:01 UTC
AutoWikiBrowser has solved this by introducing a darker shade of yellow or green on the characters themselfs.

So if:

{{Template
|Param=Foo
|Eater=Bar

changed to:

{{Template
 | Param   = Foo
 | Eater     = Bar

those spaces would would have a darker backgroud color and the diff-view itself is also in Pre-whitespace so not only is in AWB visible where the whitespace has changed also how many.

That would make great addition to the difference engine of MediaWiki.
Comment 4 Max Semenik 2010-05-08 18:18:15 UTC
A quick note on how AWB's diff system works. It employs a 3-pass system, as opposed to MediaWiki's 2 steps:
1) Line-level diff
2) Word-level diff
3) Whitespace diff, where whitespace at the end of otherwise matching words is diffed.
To render highlighted whitespace properly, it's replaced with non-breaking spaces, thus copy-pasting from diffs can yield unexpected results.

Note that I wrote AWB's diff system based on wikidiff2, not PHP diff so if they're different...
Comment 5 Nemo 2012-04-13 08:44:09 UTC
Created attachment 10417 [details]
The diff with 1.19wmf1 (r114429) and gadget "Display diffs with the new yellow/blue color scheme and design that improves accessibility. (based on r133098)"

This looks fixed (since a while ago) with the new wikidiff, made clearer by the new colours of bug 11374.

The character where there's a difference seems to always be detected correctly, and the removed/added spaces are mostly correctly highlighted in the relevant column, too. See for instance "Avionics| publisher" -> "Avionics |publisher" and "mdy}}| accessdate" -> "mdy}} |accessdate": correct point highlighted in both, but in the second only the pipe and spaces are not highlighted.
Comment 6 Nemo 2012-04-13 08:45:39 UTC
Created attachment 10418 [details]
Same diff of "Contractor selection" without style improvements

With the old style some parts of the diff were less clear but that wasn't fault of wikidiff anyway.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links