Last modified: 2010-05-15 15:37:27 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T4135, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 2135 - request for update of languagebe.php file


Summary:	request for update of languagebe.php file

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	Internationalization (Other open bugs)
Version:	1.5.x
Hardware:	PC Windows XP

Importance:	Normal normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2005-05-10 09:36 UTC by Monk
Modified:	2010-05-15 15:37 UTC (History)
CC List:	0 users

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
new version of languagebe.php (38.47 KB, text/plain) 2005-05-10 09:38 UTC, Monk	Details
patch for languagebe.php (32.13 KB, patch) 2005-05-12 17:07 UTC, Monk	Details
patch for languagebe.php (with a fix) (32.13 KB, patch) 2005-05-12 17:17 UTC, Monk	Details
patch for languagebe.php 1_4 branch (32.13 KB, patch) 2005-05-12 17:27 UTC, Monk	Details
Show Obsolete (2) Add an attachment (proposed patch, testcase, etc.)

Description Monk 2005-05-10 09:36:44 UTC

file languagebe.php is updated (many items are translated now; all mentions of
wikipedia are out now).

see attach. tested on HEAD.

Comment 1 Monk 2005-05-10 09:38:10 UTC

Created attachment 510 [details]
new version of languagebe.php

Comment 2 Ævar Arnfjörð Bjarmason 2005-05-10 22:12:42 UTC

Please:

* Submit a patch to the current file
* Use UNIX newlines rather than windows newlines (\n instead of \r\n)
* Take out Wikipedia specific stuff like 'noarticletext' => "<div
style=\"border: 1px solid #ccc; padding: 7px;\">''', in the future we might
define a cute box for those warnings in CSS but the language files should not do
it on their own, this also goes for other hardcoded styles in your patch like
the one for sharedupload and nogomatch
* Don't use the <charinsert> module in copyrightwarning, we don't ship it by
default and it shouldn't be used by default.

Thank you.

Comment 3 Monk 2005-05-12 17:07:37 UTC

Created attachment 530 [details]
patch for languagebe.php

patch; all recommendations of Ævar followed.

Comment 4 Ævar Arnfjörð Bjarmason 2005-05-12 17:17:24 UTC

Applied to HEAD.

Comment 5 Monk 2005-05-12 17:17:31 UTC

Created attachment 531 [details]
patch for languagebe.php (with a fix)

previous version lacked the important comma

Comment 6 Monk 2005-05-12 17:27:21 UTC

Created attachment 532 [details]
patch for languagebe.php 1_4 branch

Patch for 1_4 branch (Revision 1.1.2.3)

Note You need to log in before you can comment on or make changes to this bug.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links