Last modified: 2011-10-25 20:27:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T23211, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 21211 - Change SVN post-commit hooks to not block while notifications go out
Change SVN post-commit hooks to not block while notifications go out
Status: RESOLVED WONTFIX
Product: Wikimedia
Classification: Unclassified
Subversion (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Chad H.
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2009-10-20 21:41 UTC by Brion Vibber
Modified: 2011-10-25 20:27 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Brion Vibber 2009-10-20 21:41:34 UTC 
Our post-commit hooks run several notifications, at least:

* email w/ diff to mediawiki-cvs
* CIA ping
* mediawiki.org CodeReview ping

These are run with & to background them, but I don't think the whole script actually exits until they're done; this leads to 'svn commit' taking several seconds longer to return than it should, which is frustrating to devs.

The notifications should either be fully backgrounded without blocking the parent shell script, or they should be run from a separate process after the revision is added to a job queue of some kind.
Comment 1 Chad H. 2011-03-09 00:35:04 UTC 
Taking this from Brion, I'm more likely to do it than he is :D
Comment 2 Chad H. 2011-10-25 20:27:21 UTC 
Who cares? We're moving to git anyway ;-)
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links