Last modified: 2009-10-20 20:24:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T22911, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 20911 - [patch] SQLite install does not check database existence
[patch] SQLite install does not check database existence
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Installer (Other open bugs)
1.16.x
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch
Depends on:
Blocks: sqlite
  Show dependency treegraph
 
Reported: 2009-09-30 18:26 UTC by Antoine "hashar" Musso (WMF)
Modified: 2009-10-20 20:24 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
check db file existence in mw installer. (1.07 KB, patch)
2009-09-30 18:26 UTC, Antoine "hashar" Musso (WMF)
Details

Description Antoine "hashar" Musso (WMF) 2009-09-30 18:26:38 UTC
Created attachment 6607 [details]
check db file existence in mw installer.

When installing MediaWiki@57115 with SQLite support, the installer does not check if the database file exist.

The attached patch:
- check the file exist before checking its writable status
- correct a minor typo when writing the 'ok' status.
Comment 1 Max Semenik 2009-09-30 19:23:44 UTC
Hmm, why should it need to create the DB first? As SQLite is stateless and permissionless, it doesn't need any special procedure for database setup. It makes sense to keep the current behaviour that creates the database file transparently if it doesn't exist yet, just like MySQL installer creates the needed database on its own.
Comment 2 Antoine "hashar" Musso (WMF) 2009-10-02 19:10:46 UTC
With r57115 on Mac OSX, it did not create the database. That's why I added a warning message, it is better than the "Wiki has a problem" page.

I will have a look at the root issue.
Comment 3 Antoine "hashar" Musso (WMF) 2009-10-13 19:59:18 UTC
Still trying to track the issue. I am kind of new to Mac OS, so that's a bit hard to track for me.
Comment 4 Max Semenik 2009-10-20 20:24:03 UTC
Fixed in  r57959

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links