Last modified: 2014-02-12 15:57:07 UTC
See the picture in attachment: the external links have a big padding before.
This does not happens on the online version.
For an unknown reason, replacing "padding: 0 npx" by "padding-rigth: npx" resolves the issue without impacting the online version (see the patch in attachment)
Created attachment 6586 [details]
Modifications I have done to (partly) resolve the issue
The problem rootcause is that in the SkinOffline.php the ltr/rtl class is not defined in the <body> CSS attribute. So please forget the previous patch, this is wrong.
Created attachment 7811 [details]
add rtl/ltr class to body of dumphtml
Fixing this is easy enough, see patch, but that leaves all the other "special" parts that a head can have. SkinOffline should be fixed to better reuse the <head> element of Skin.php I think.
@ Derk-Jan Hartman
Yes this is what I have done on my mirror.
Givng dump bugs to Ariel.
who should be getting dumpHTML bugs?
Ariel, I think technically Tim Starling is the maintainer, so you could fling it to him.
Derk-Jan, can I ask you to push this as a Gerrit merge request? Thanks.
Related URL: https://gerrit.wikimedia.org/r/60194 (Gerrit Change I3ca7102d40579b43af56e14b3f4bd8ddd33fb232)
Change 60194 merged by jenkins-bot:
SkinOffline: Add rtl/ltr classes to body
Patch got merged - can this bug report be closed as RESOLVED FIXED or is more work required?
No reply to comment 11 - assuming this is FIXED.
Please reopen and elaborate which work is left, if that is not the case.