Last modified: 2014-02-12 15:57:07 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T22828, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 20828 - CSS with external links does not work well
CSS with external links does not work well
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
DumpHTML (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2009-09-26 17:18 UTC by Kelson [Emmanuel Engelhart]
Modified: 2014-02-12 15:57 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Modifications I have done to (partly) resolve the issue (168 bytes, patch)
2009-09-26 17:20 UTC, Kelson [Emmanuel Engelhart] 		Details
add rtl/ltr class to body of dumphtml (846 bytes, patch)
2010-11-10 19:46 UTC, Derk-Jan Hartman 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Kelson [Emmanuel Engelhart] 2009-09-26 17:18:38 UTC 
See the picture in attachment: the external links have a big padding before.
This does not happens on the online version.
For an unknown reason, replacing "padding: 0 npx" by "padding-rigth: npx" resolves the issue without impacting the online version (see the patch in attachment)
Comment 1 Kelson [Emmanuel Engelhart] 2009-09-26 17:20:42 UTC 
Created attachment 6586 [details]
Modifications I have done to (partly) resolve the issue
Comment 2 Kelson [Emmanuel Engelhart] 2010-11-10 11:52:53 UTC 
The problem rootcause is that in the SkinOffline.php the ltr/rtl class is not defined in the <body> CSS attribute. So please forget the previous patch, this is wrong.
Comment 3 Derk-Jan Hartman 2010-11-10 19:46:56 UTC 
Created attachment 7811 [details]
add rtl/ltr class to body of dumphtml

Fixing this is easy enough, see patch, but that leaves all the other "special" parts that a head can have. SkinOffline should be fixed to better reuse the <head> element of Skin.php I think.
Comment 4 Kelson [Emmanuel Engelhart] 2010-11-11 09:57:15 UTC 
@ Derk-Jan Hartman

Yes this is what I have done on my mirror.
Comment 5 Mark A. Hershberger 2011-05-03 18:56:57 UTC 
Givng dump bugs to Ariel.
Comment 6 Ariel T. Glenn 2011-09-18 09:32:31 UTC 
who should be getting dumpHTML bugs?
Comment 7 Sumana Harihareswara 2012-01-14 22:56:41 UTC 
Ariel, I think technically Tim Starling is the maintainer, so you could fling it to him.
Comment 8 Sumana Harihareswara 2012-05-23 20:00:18 UTC 
Derk-Jan, can I ask you to push this as a Gerrit merge request? Thanks.
Comment 9 Gerrit Notification Bot 2013-04-21 13:51:12 UTC 
Related URL: https://gerrit.wikimedia.org/r/60194 (Gerrit Change I3ca7102d40579b43af56e14b3f4bd8ddd33fb232)
Comment 10 Gerrit Notification Bot 2013-07-03 13:18:14 UTC 
Change 60194 merged by jenkins-bot:
SkinOffline: Add rtl/ltr classes to body

https://gerrit.wikimedia.org/r/60194
Comment 11 Andre Klapper 2013-09-25 09:48:17 UTC 
Patch got merged - can this bug report be closed as RESOLVED FIXED or is more work required?
Comment 12 Andre Klapper 2014-02-12 15:57:07 UTC 
No reply to comment 11 - assuming this is FIXED.
Please reopen and elaborate which work is left, if that is not the case.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links