Last modified: 2012-09-27 01:11:05 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T22698, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 20698 - Weird font sizes in jsMsg and line-heights on <div> wrapped content on vector
Weird font sizes in jsMsg and line-heights on <div> wrapped content on vector
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
1.16.x
All All
: Normal minor (vote)
: ---
Assigned To: Nimish Gautam
http://en.wikipedia.org/w/index.php?t...
: code-update-regression
: 20672 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-09-17 19:31 UTC by Bawolff (Brian Wolff)
Modified: 2012-09-27 01:11 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Bawolff (Brian Wolff) 2009-09-17 19:31:39 UTC
On the new version of vector that just went live on wikimedia, there seems to be two issues relating to font sizes:

*Javascript messages (as in the stuff made through the jsMsg() function, like the watchlist stuff) Is way way too big
*If while editing you wrap any content in a div (or table or center or really any block element as far as i can tell), (and so there are no <p>'s inside). You get huge line-heights. (ex http://en.wikipedia.org/w/index.php?title=Wikipedia:Sandbox&oldid=314574648 )
**Also related is the line-heights on the category box at the bottom of the page seems a bit big, but thats just my opinion.

On the english Wikinews, to work arround these issues (I assume these are issues, they are not the behavoir i expect, but it could be concievable that it is intentional) we added the following style rules to [[n:mediawiki:Vector.css]]:

#mw-js-message {font-size: 0.8em;}
div#bodyCotent  {line-height: 1.5em;}


I think they should probably be added to main-ltr.css and main-rtl.css stylesheets.

Anyways, I hope this is the right place to report this and all. Cheers, and thank you for all the great work on vector, its an excellent skin.

-bawolff
Comment 1 Bawolff (Brian Wolff) 2009-09-17 19:32:58 UTC
Sorry. I made a typo. I meant div#bodyContent  {line-height: 1.5em;} not div#bodyCotent  {line-height: 1.5em;}

Comment 2 Bawolff (Brian Wolff) 2009-09-17 19:54:03 UTC
doing this also appears to fix having too big a line-height on special:watchlist
Comment 3 Brion Vibber 2009-09-17 21:19:16 UTC
Assigning to Nimish as Trevor's currently out on paternity leave.
Comment 4 Nimish Gautam 2009-09-17 23:16:24 UTC
hm, it looks like adding div#bodyContent {line-height: 1.5em;} squishes the table of contents, images, and other things inside DIVs on other pages...are you seeing that on en wikinews as well?
Comment 5 Bawolff (Brian Wolff) 2009-09-17 23:27:55 UTC
I only have firefox to test on. The ToC is slightly more squished, but you'd
only see it if you were looking for it (and your directly on the page,
toggeling the rule on and off with firebug. I don't think i'd notice it without
seeing the text move slightly while toggoling it). Does not seem to affect
images at all (tested the normal thumb images and galleries) It does shrink the
line-height on one of our templates that uses tables to make a fancy caption
thing - [[n:Template:News in pictures]] (I would say that template had
abnormally large line-height before, so that was a good thing). It does shrink
the padding on headlines slightly.

I tested the toggle on off of this rule on [[n:Main Page]] and [[n:Wikinews
international report: "Anonymous"_holds_anti-Scientology protests worldwide]]
(it had lots of images).

cheers
Comment 6 Bawolff (Brian Wolff) 2009-09-18 00:52:32 UTC
I am noticing what appears to css scaling on images on wikinews. It is quite likely that the css rules i suggested are the cause of it since it does not appear on 'pedia. (I'm not really sure why it would cause that). In your previous message i thought you meant the text arround the image, not the image itself.
Comment 7 Bawolff (Brian Wolff) 2009-09-18 01:30:35 UTC
Nevermind, I accidently hit zoom on firefox without realizing it. The images are not being scaled as far as i can tell.
Comment 8 Alexey Bobyakov 2009-09-18 07:31:54 UTC
*** Bug 20672 has been marked as a duplicate of this bug. ***
Comment 9 Nimish Gautam 2009-09-18 22:05:00 UTC
Yeah, the condensing isn't too much different from monobook, fixed in r56624

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links