Last modified: 2010-11-05 15:51:35 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T4020, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 2020 - BiDi related issues to ";", ":", "#", and "*", monobook skin etc.
BiDi related issues to ";", ":", "#", and "*", monobook skin etc.
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
unspecified
All All
: High major with 2 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
http://yi.wikipedia.org/wiki/User:Dan...
: patch, patch-need-review
: 6221 (view as bug list)
Depends on:
Blocks: rtl
  Show dependency treegraph
 
Reported: 2005-04-29 22:20 UTC by lɛʁi לערי ריינהארט
Modified: 2010-11-05 15:51 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Sample XHTML page (1.52 KB, text/html)
2005-06-19 05:14 UTC, Zigger
Details
REL1_4 patch for Monobook main.css, rtl.css (1.21 KB, patch)
2005-06-19 05:16 UTC, Zigger
Details
HEAD patch for Monobook main.css, rtl.css (1.18 KB, patch)
2005-06-19 05:16 UTC, Zigger
Details

Description lɛʁi לערי ריינהארט 2005-04-29 22:20:14 UTC
Hi!
I have seen a great discrepancy between the Monobook and calsic Skins.
At http://yi.wikipedia.org/wiki/Image:Yi_wikipedia_-_ltr_-_monobook_-_clasic.jpg
you can see that identations using
#foo (new line)
##bar
FAIL at yi.wp (rtl wiki) in the Monobook skin

The corrsponding URL is
http://yi.wikipedia.org/wiki/User:Danny/todos#problems_to_be_fixed_by_developers .

Regards Reinhardt [[user:gangleri]]
Comment 1 Brion Vibber 2005-04-30 04:11:48 UTC
Changed summary to describe the problem.
Comment 2 lɛʁi לערי ריינהארט 2005-06-14 13:01:22 UTC
changed severity to major as using LTR blocks on RTL wikis a lot
Comment 3 Zigger 2005-06-19 05:11:09 UTC
The problem occurs in any list with a RTL box on a LTR wiki, as well as a LTR
box on a RTL wiki.  It occurs whether the direction-marking occurs on the
list-item, the list, or a div around the list.  REL1_4 and HEAD both have the
problem.

The CSS1 and CSS2.1 specifications place list-item markers outside the list-item
"box", for the default list-style-position.  Both the Gecko and IE layout
engines can place these markers outside the parent boxes completely.

The Monobook main.css sets lists to have no padding, no right-hand margin and a
left margin of 3.2em.  rtl.css reverses the horizontal margins for lists,
although with a smaller margin for ordered lists.  TOC styles overide the
horizontal margins separately.

One simple fix is to change main.css to make the left margin the same size as
the right margin.  This removes the need to override the horizontal margins in
rtl.css.  This could be applied to the MediaWiki releases, or just done as a
customisation per site or per user.

The down-side of this fix is that the extra margin wastes horizontal space,
which may be an issue inside table columns.  It can be overridden using tags
instead of wikisyntax.

I'll attach sample XHTML, and the patches for this fix.

(Although the default padding for Firefox 1.04 and IE6-SP1 is already 0, I've
left it in the CSS in case someone put it there for other browsers that may have
different defaults.)

The sample uses colored borders to show how CSS works for this problem.  A.1
shows the current behaviour, and A.2 shows the effect of the patch.  B & C show
the effect of changing the list padding.
Comment 4 Zigger 2005-06-19 05:14:20 UTC
Created attachment 618 [details]
Sample XHTML page
Comment 5 Zigger 2005-06-19 05:16:15 UTC
Created attachment 619 [details]
REL1_4 patch for Monobook main.css, rtl.css
Comment 6 Zigger 2005-06-19 05:16:53 UTC
Created attachment 620 [details]
HEAD patch for Monobook main.css, rtl.css
Comment 7 lɛʁi לערי ריינהארט 2005-11-11 20:45:57 UTC
see also
bug 3929: make ٭ equivalent to *
Comment 9 lɛʁi לערי ריינהארט 2006-01-19 12:42:31 UTC
Please take a look at bug 4521 comment 6
Bug 4521: Definition list abused for indentation purposes
Comment 10 Scarlight 2006-06-14 19:13:35 UTC
*** Bug 6221 has been marked as a duplicate of this bug. ***
Comment 11 Mark A. Hershberger 2010-11-05 15:51:35 UTC
Just tested this against the sample text and got the expected indentation on both monobook, classic and vector.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links