Last modified: 2009-08-15 09:58:22 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T21788, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 19788 - CodeReview wrongly marks revs as live due to wmf-development branch
CodeReview wrongly marks revs as live due to wmf-development branch
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CodeReview (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Aaron Schulz
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-07-17 16:27 UTC by Roan Kattouw
Modified: 2009-08-15 09:58 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Roan Kattouw 2009-07-17 16:27:37 UTC
Wikipedia is now running r53381 of the wmf-development branch, which causes Special:Code to mark all revs up to and including r53381 with the mw-codereview-live class. Obviously, this is not correct, since most revs to trunk and extensions between r53381 and r52088 aren't actually live.
Comment 1 Brion Vibber 2009-08-04 21:49:51 UTC
Marking this as normal bug, not enhancement. It is a loss of functionality. :(
Comment 2 Aaron Schulz 2009-08-15 03:16:02 UTC
Disabled by default now, instead of randomly assuming "MediaWiki". This makes no sense when we have concurrent branches.

It would be nice to automatically show what revisions are live, even better than before, where scattered revision that were synced also are highlighted. This is pretty non-trivial. A cheaper system of manually setting the live revision and tagging the hotfix revisions would be easier to implement.
Comment 3 Roan Kattouw 2009-08-15 09:58:22 UTC
(In reply to comment #2)
> Disabled by default now, instead of randomly assuming "MediaWiki". This makes
> no sense when we have concurrent branches.
> 
> It would be nice to automatically show what revisions are live, even better
> than before, where scattered revision that were synced also are highlighted.
> This is pretty non-trivial. A cheaper system of manually setting the live
> revision and tagging the hotfix revisions would be easier to implement.
> 

We already use the wmf-deployment tag (and previously the live tag) for hotfix revisions, so we could just give this tag special treatment.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links