Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T21751, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 19751 - Image undelete inadequately checks filesystem status before deleting archive info from DB (data loss)

Summary:	Image undelete inadequately checks filesystem status before deleting archive ...

Status: RESOLVED FIXED Product: MediaWiki Classification: Unclassified Component: File management (Other open bugs) Version: unspecified Hardware: All All Importance: Normal major (vote) Target Milestone: --- Assigned To: Chad H. URL: Whiteboard: Keywords: Depends on: Blocks:   Show dependency tree / graph		Reported: 2009-07-15 21:55 UTC by Brion Vibber Modified: 2011-02-04 20:56 UTC (History) CC List: 2 users (show) Bryan.TongMinh gpaumier See Also: Web browser: --- Mobile Platform: --- Assignee Huggle Beta Tester: ---

Attachments Add an attachment (proposed patch, testcase, etc.)

Description Brion Vibber 2009-07-15 21:55:30 UTC Image undelete appears not to be confirming that the file was properly re-written to the filesystem before removing the archive info from the undeletion tables. (filearchive) This can result in for instance a useless 0-byte file sitting there: http://upload.wikimedia.org/wikipedia/de/7/70/KKH-Allianz_Hauptverwaltung.png http://de.wikipedia.org/wiki/KKH-Allianz_Hauptverwaltung.png Comment 1 Chad H. 2009-11-28 04:41:57 UTC Mass component change for merge of "File/Repo" and "Images and Files" Comment 2 Bryan Tong Minh 2011-02-04 20:56:34 UTC r81536