Last modified: 2009-07-13 20:50:00 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T21693, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 19693 - User name Special:BlockIP is not HTML escaped
User name Special:BlockIP is not HTML escaped
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
unspecified
All All
: Highest critical (vote)
: ---
Assigned To: Nobody - You can work on this!
http://en.wikipedia.org/wiki/Special:...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-07-13 09:32 UTC by Amalthea
Modified: 2009-07-13 20:50 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Amalthea 2009-07-13 09:32:02 UTC
Specifically, in the div#mw-ipb-conveniencelinks the name of the contributions link is not escaped.

SpecialBlockip.php, function getContribsLink

See also related Bug 19517.
Comment 1 River Tarnell 2009-07-13 09:40:39 UTC
please don't report critical security issues in the public bug tracker; the email address security [at] wikimedia.org exists for that purpose.
Comment 2 Alexandre Emsenhuber [IAlex] 2009-07-13 09:44:05 UTC
fixed in r53159.
Comment 3 Amalthea 2009-07-13 10:24:39 UTC
Alright, next time, but this is nowhere near critical. User names are pretty heavily restricted anyways, and to the best of my knowledge, the only possible exploit of this one would be to provoke display inconsistencies, since browsers display a "&lt" as a "<". You can't have plain angle brackets in your user name.
Comment 4 Alexandre Emsenhuber [IAlex] 2009-07-13 19:08:39 UTC
User names are restricted, this is correct, but the link to Special:Contribution doesnt check for that, so you could link to Special:Block?ip=<script>...</script> (or anything else) and it was passed raw to the user.
Comment 5 Amalthea 2009-07-13 20:50:00 UTC
Yowsa, ok, I just didn't realize the severity then, I didn't look into it that deeply.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links