Last modified: 2011-03-13 18:05:43 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T21200, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 19200 - Edit summary label broken
Edit summary label broken
Status: RESOLVED WONTFIX
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
1.16.x
All All
: Lowest normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 19250 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-06-15 09:14 UTC by MER-C
Modified: 2011-03-13 18:05 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot (51.30 KB, image/png)
2009-06-15 09:14 UTC, MER-C
Details

Description MER-C 2009-06-15 09:14:09 UTC
Created attachment 6223 [details]
Screenshot

If [[MediaWiki:Summary]] contains HTML, after the scap to r51863 the label for the edit summary text field reads

<a href="/wiki/Help:Edit_summary" class='internal' title="Briefly describe the changes you have made" target="_blank">Edit summary</a> (Briefly describe the changes you have made)

The HTML should actually be rendered by the browser. Confirmed on en and simple.

http://simple.wikipedia.org/w/index.php?title=Wikipedia:Sandbox&action=edit

Screenshot attached
Comment 1 Siebrand Mazeland 2009-06-15 09:22:41 UTC
Looks like this behaviour may have been changed in r50882
Comment 2 Andrew Garrett 2009-06-15 09:24:32 UTC
Changing messages from HTML to wikitext is a good idea generally.
Comment 3 Stifle 2009-06-15 09:36:30 UTC
The < has been changed to a &lt; entity, which is why it doesn't render. (System message affected is MediaWiki:Summary.) Siebrand has identified the correct change, I think. The message uses HTML rather than wikitext because it wishes to open the link to Help:Edit summary in a new window (which I don't think wikitext can do). If it opens in the same window, users of suboptimal browsers who click to read about edit summaries will lose any edits they've made when clicking the back button.
Comment 4 Siebrand Mazeland 2009-06-15 10:57:13 UTC
WONTFIX per comment 2.
Comment 5 Splarka 2009-06-16 10:06:04 UTC
To anyone directed here from WMF wikis:

Per the WONTFIX, I've enlisted some steward help to remove some of the more awful breaks in this message.

Note that it was a valid concern to use <a target="_new"> or _blank or such for browsers that would not cache the edit page if you left it, but inserting raw <script> into this message is very bad. Please migrate any javascript to MediaWiki:Common.js (for things like addTags, use innerHTML or createElement to add the links anywhere on the edit page). The <a target> can also be done via javascript http://en.wikipedia.org/wiki/User:Dinoguy1000/scripts/safeIEeditlinks.js (though this is a stopgap fix).
Comment 6 OverlordQ 2009-06-16 23:09:26 UTC
*** Bug 19250 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links