Last modified: 2010-07-01 23:21:24 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T20870, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 18870 - The toggle defined in $extraUserToggles won't display in the user preferences
The toggle defined in $extraUserToggles won't display in the user preferences
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
User preferences (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Andrew Garrett
:
Depends on: 18410
Blocks: 18958
  Show dependency treegraph
 
Reported: 2009-05-22 04:54 UTC by Shinjiman
Modified: 2010-07-01 23:21 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Shinjiman 2009-05-22 04:54:49 UTC
As of the current working copy in the trunk, seems the 
options defined in "$extraUserToggles" does not appear in 
the user preferences. The "$wgLanguageCode" value had been 
set with the "$extraUserToggles" value already defined, 
such as 'zh' and 'kk-cyrl'.
Comment 1 Shinjiman 2009-05-22 04:57:33 UTC
This one blocks bug 18410.
Comment 2 Brion Vibber 2009-05-26 21:09:45 UTC
Andrew, this refers to additional preference toggles which are language-specific, grabbed via Language::getExtraUserToggles().

They're listed in the message files in $extraUserToggles. This seems to be used primarily to add a 'nolangconversion' toggle for kk, sr, and zh.
Comment 3 Shinjiman 2009-05-28 17:57:11 UTC
Indeed, the $extraUserToggles should be grabbed based on the content language
instead of the user languages.
Comment 4 Shinjiman 2009-06-01 11:41:34 UTC
(In reply to comment #3)
> Indeed, the $extraUserToggles should be grabbed based on the content language
> instead of the user languages.

And the way to display the text should be showing based on the user language.
Comment 5 Andrew Garrett 2009-06-03 16:45:28 UTC
Fixed in r51417.
Comment 6 Andrew Garrett 2009-06-04 09:59:52 UTC
Moved blockers to dependencies because they don't block it and I don't want to get mail about them.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links